Fix compile error: use correct HapticEngine.play() and SoundEngine.play() methods#1
Open
madebyshaurya wants to merge 1 commit into
Open
Fix compile error: use correct HapticEngine.play() and SoundEngine.play() methods#1madebyshaurya wants to merge 1 commit into
madebyshaurya wants to merge 1 commit into
Conversation
View+MicroInteractions.swift called HapticEngine.shared.generateFeedback(for:) and SoundEngine.shared.playSound(for:), but these methods don't exist. The correct APIs are HapticEngine.shared.play(_:) and SoundEngine.shared.play(_:). This caused a compile error when integrating via SPM: error: value of type 'HapticEngine' has no member 'generateFeedback' Fixed by extracting haptic/sound styles from the interaction's feedbackType and calling the correct play() methods.
madebyshaurya
added a commit
to madebyshaurya/SpendSmart
that referenced
this pull request
Mar 25, 2026
Fixed the library's compile error (HapticEngine.generateFeedback doesn't exist, should be HapticEngine.play). Using our fork at madebyshaurya/SwiftMicroInteractions. PR submitted to upstream: DAWNCR0W/SwiftMicroInteractions#1 Applied .microInteraction(.toggle) to batch mode toggle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
View+MicroInteractions.swiftcalls methods that don't exist:HapticEngine.shared.generateFeedback(for:)SoundEngine.shared.playSound(for:)This causes a compile error when integrating via SPM:
Fix
The correct APIs (defined in
HapticEngine.swiftandSoundEngine.swift) are:HapticEngine.shared.play(_ style: HapticStyle)SoundEngine.shared.play(_ style: SoundStyle)Added a
playFeedback(for:)helper that extracts the haptic/sound styles from the interaction'sfeedbackTypeand calls the correct methods. Handles.combinedfeedback types recursively.Testing
Verified the fix compiles successfully in an iOS 18.0+ project using SPM.