fix(ui): apply UI audit batch 1-4#3
Merged
Merged
Conversation
Address findings from the taste-skill UI audit: 1. Load Manrope locally via @fontsource-variable/manrope. The font-family referenced "Manrope" but it was never bundled, so every surface silently fell back to Segoe UI. Bundled (no CDN) to preserve the no-network policy. 2. Split editor status into success/error kinds so confirmations render in emerald, not the error red that previously made successes look like failures. 3. Replace popup window.alert() with an inline aria-live error message. 4. Accessibility: fix inverted heading order (h3 -> h4 for card subsections), wrap editor status/progress in aria-live, and make the editor root a <main>. Also adds CLAUDE.md guidance for future Claude Code sessions. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
DCCA
pushed a commit
that referenced
this pull request
Jun 22, 2026
PRs #3-#5 (UI refactor) and a new CLAUDE.md landed on main without Prettier formatting, so the format:check gate added in the hardening sweep failed on main. Format the 4 offending files (CLAUDE.md, badge.tsx, editor/main.tsx, viewer/main.tsx). No logic changes. All gates pass locally: typecheck, lint, format:check, test (34), build. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PJ5c2e5VcKVhugy7TAzi4W
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applies fixes 1–4 from the taste-skill UI audit of the popup/editor/viewer surfaces. These are correctness and accessibility fixes, not cosmetic changes.
font-familyreferenced"Manrope"but the font was never bundled, so every surface silently fell back to Segoe UI. Added@fontsource-variable/manropeas a local dependency (no CDN — preserves the extension's no-network policy) and wired it intoglobals.css. woff2 files now ship indist/assets/.statusstring rendered everything in error-red, so "link copied" confirmations looked like failures.statusis now{ kind: "success" | "error"; message }and renders emerald for success.window.alert. The popup's "No active tab" path now shows an inlinearia-liveerror instead of a native alert.h2→h4under theh3card title), wrapped editor status/progress inaria-live="polite", and made the editor root a<main>landmark.Also adds
CLAUDE.mdfor future Claude Code sessions.Verification
npm run check(typecheck + lint + 26 tests + build) — all greenOut of scope
Remaining polish items from the audit (pressed states,
tabular-nums, destructive-button placement,100dvh) are intentionally deferred.🤖 Generated with Claude Code