Skip to content

Conversation

@ameliabrey
Copy link
Contributor

OP#1467

@ameliabrey ameliabrey requested a review from johentsch March 24, 2025 18:37
@johentsch johentsch changed the base branch from main to op2 May 20, 2025 15:40
Copy link
Member

@johentsch johentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ameliabrey. Please adapt the figure durations to the new guideline, e.g. the figures in mm. 9 or 11 should have default durations. Also, I'm nut sure about the trill lines, I think a mere tr mark is what's needed here (and if the trill in m. 34 can be encoded with Bb, I think that would be appropriate). The score has not been extracted, please use the pre-commit hook or the review command.

@ameliabrey
Copy link
Contributor Author

MuseScore doesn't actually have a means of encoding a different trill pitch without adding invisible notes; this is a problem I've struggled with in my own music. This issue hasn't been addressed in MS4 either.
We have the dilemma that any interface for these scores that relies upon playback will have the wrong pitches, but then on the other hand adding invisible notes would affect the extracted files.

@ameliabrey
Copy link
Contributor Author

apologies for my previous confusion regarding how to get the new score to extract!

… close the file but I don't know what that is
@ameliabrey
Copy link
Contributor Author

ameliabrey commented May 21, 2025

In this most recent commit I used the git merge -Xtheirs main command to deal with the readme conflicts but they're still showing up

@johentsch johentsch mentioned this pull request Nov 10, 2025
@johentsch
Copy link
Member

Superseded by #281

@johentsch johentsch closed this Nov 10, 2025
@johentsch johentsch deleted the op02n02b branch November 10, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants