Skip to content

Fix parent deletion on relation deletion #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yrammos merged 4 commits into from
Jul 28, 2025
Merged

Fix parent deletion on relation deletion #356

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d57ae46
fix: relation layer would not delete parent
Crowerade Jul 24, 2025
122eed0
chore: remove console log
Crowerade Jul 25, 2025
b1ea24b
fix: parent deletion would overdelete some edges
Crowerade Jul 28, 2025
0294f8b
Merge branch 'develop' into fix-parent-deletion-on-relation-deletion
Crowerade Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions src/js/action/delete.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ function delete_relation(elem) {
const sourceElement = get_by_id(mei, fromId)

// If the source is a metarelation, add the target as a child ID
// TODO: Why?
if (sourceElement && sourceElement.getAttribute('type') === 'metarelation') {
childIds.add(toId)
}
Expand All @@ -86,14 +87,14 @@ function delete_relation(elem) {

// After deletion, check if any children need their connection circles removed
// Store the returned connection circle data for undo
if (childIds.size > 0) {
const connectionCircleData = updateConnectionCircles(Array.from(childIds))
// if (childIds.size > 0) {
// const connectionCircleData = updateConnectionCircles(Array.from(childIds))

// Add connection circle data to the action_removed array if any was removed
if (connectionCircleData.length > 0) {
action_removed.push(['connection_circle_data', connectionCircleData])
}
}
// // Add connection circle data to the action_removed array if any was removed
// if (connectionCircleData.length > 0) {
// action_removed.push(['connection_circle_data', connectionCircleData])
// }
// }

// Adjust SVG dimensions after deletion
draw_contexts.forEach(draw_context => {
Expand Down Expand Up @@ -210,7 +211,9 @@ function find_all_parent_relations(elem, mei, draw_contexts, svg_hes, processedI
let meta_relations = []
let meta_relation_arcs = []

const elemId = elem.id || get_id(elem)
const elemId = elem.id
? elem.id.slice(elem.id.search(/[^\d]/))
: get_id(elem)

// Find arcs that connect meta-relations to this relation
// Only look for arcs where this element is the target (to) - parent->child
Expand Down