Admin utilities to display form versions#1376
Merged
alexluckett merged 38 commits intomainfrom Apr 13, 2026
Merged
Conversation
Adds formInspect to session names, creates an empty route file, wires it into the admin index routes/supports/scope, and adds a conditional link in the admin index view gated on the FormsInspect scope.
This reverts commit c96fc0b.
… routes and access control tests
… to accessible-autocomplete-enhance
- Add braces to braceless if statements in objectHash - Extract duplicated string literals to module-level constants - Rename shadowed joiError variable in slug-not-found catch block - Use replaceAll over replace for XSS-strip regex - Darken deleted-text colour in diff view to meet AA contrast (3.67 → 5.28:1) - Add tests for error rethrow paths and objectHash branch coverage
alexluckett
force-pushed
the
feature/admin-utilities-forms-versions
branch
from
56eea8d to
845071d
Compare
jbarnsley10
reviewed
Apr 13, 2026
jbarnsley10
reviewed
Apr 13, 2026
jbarnsley10
reviewed
Apr 13, 2026
jbarnsley10
reviewed
Apr 13, 2026
jbarnsley10
reviewed
Apr 13, 2026
jbarnsley10
reviewed
Apr 13, 2026
| </div> | ||
| {% endmacro %} | ||
|
|
||
| {% macro appJsonDisplay(data) %} |
Contributor
There was a problem hiding this comment.
Nice that this is now a macro. Is the DLQ stuff now using this macro or is that another PR?
Contributor
Author
There was a problem hiding this comment.
Good point, I forgot to refactor that. I'll do that as a follow-up.
jbarnsley10
approved these changes
Apr 13, 2026
Contributor
jbarnsley10
left a comment
jbarnsley10
left a comment
There was a problem hiding this comment.
Excellent work. A couple of minor comments (and probs the 404 try/catches I now realise are because your page might display things like 'No draft versions for this form' etc), so probs ok.
Obvs forms-entitlement-api will need a model bump once this PR is mergd to pick up the new extra scope on superadmin.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new Form Inspect developer tool to the admin area, gated behind a new FormsInspect scope (superadmin only). The tool lets administrators look up any form by ID or slug and inspect its state across several tabs.
What's included
Form Inspect routes (/admin/form-inspect)