2683 - Correct the directory structure#397
Merged
Merged
Conversation
SummarySummary
CoverageSAPData - 79.8%
SAPPub.Core - 76.9%
SAPPub.Infrastructure - 62.5%
SAPPub.Web - 86.9%
|
school/100273/saint-paul-roman-catholic-infant-school/secondary/destinations
https://127.0.0.1:36917/school/100273/saint-paul-roman-catholic-infant-school/secondary/destinations Target: #current-view Target: #data-overtime-view school/100273/saint-paul-roman-catholic-infant-school/secondary/academic-performance-english-and-maths-results
https://127.0.0.1:36917/school/100273/saint-paul-roman-catholic-infant-school/secondary/academic-performance-english-and-maths-results Target: #current-view Target: #data-overtime-view |
nomankhans21
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Update the validate infra workflow to match the directory structure.
https://trello.com/c/p76gfyrn/2683-schedule-validate-infra-workflow
Changes proposed in this pull request
Update the terraform_base and terraform_version_file variables.
Guidance to review
Run the "Validate Infra" workflow as it already exists for the service. You can point it at the branch but that will always produce a false positive as the docker image will be different for main and the branch but you should see that the structure is correct and it's just the sha that's different. This will produce a workflow Teams message in SD Infra Alerts Teams channel.
There are 3 jobs in the workflow, AKS infrastructure, Domains infrastructure and Domains environment. The workflow card will show which job to look at in the bottom left corner (Infrastructure in the image above). You can click the Workflow Run button to go to the correct run.
The jobs must show a green tick not a red cross.
You can alter any value in the terraform production.tfvars.json in your branch to check that the terraform plan picks up those changes, remembering that the docker image is a false positive.
Checklist
Devopslabel