Feature/537 add phase to the about the school page by stuw-dfe · Pull Request #398 · DFE-Digital/sap-public

stuw-dfe · 2026-06-22T10:11:02Z

Description

Add Education Phase to school profiles: https://trello.com/c/Ut5TKvRd/537-add-phase-to-the-about-the-school-page

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Manual and automated tests

…l-page

github-actions · 2026-06-22T10:20:30Z

Review app for PR 398 was deleted

github-actions · 2026-06-22T10:31:35Z

Summary


Generated on:	06/22/2026 - 10:31:32
Parser:	Cobertura
Assemblies:	4
Classes:	121
Files:	118
Line coverage:	79.5% (2375 of 2984)
Covered lines:	2375
Uncovered lines:	609
Coverable lines:	2984
Total lines:	7729
Branch coverage:	71.8% (372 of 518)
Covered branches:	372
Total branches:	518
Method coverage:	Feature is only available for sponsors

Coverage

SAPData - 79.8%

Name	Line	Branch
SAPData	79.8%	64.4%
SAPData.Filters.SqlViewFilterProvider	100%	100%
SAPData.GenerateIndexes	100%	100%
SAPData.GenerateRawTables	58.6%	39%
SAPData.GenerateViews	86.8%	83.7%
SAPData.Models.DataMapMapping	0%

SAPPub.Core - 78.2%

Name	Line	Branch
SAPPub.Core	78.2%	100%
SAPPub.Core.Enums.Progress8BandingExtensions	100%	100%
SAPPub.Core.Exceptions.NotFoundException	100%
SAPPub.Core.Extensions.DoubleExtensions	100%
SAPPub.Core.Extensions.EducationPhaseFormatter	100%	100%
SAPPub.Core.Extensions.EstablishmentExtensions	100%
SAPPub.Core.Extensions.EstablishmentStatusExtensions	94.7%	100%
SAPPub.Core.Extensions.SchoolSearchDocumentExtensions	100%
SAPPub.Core.Extensions.StringExtensions	100%	100%
SAPPub.Core.Helpers.AcademicYearsHelper	100%
SAPPub.Core.Helpers.MappingHelper	88.8%	100%
SAPPub.Core.Helpers.TextHelpers	86.6%	100%
SAPPub.Core.ServiceModels.Common.Pager	75%
SAPPub.Core.ServiceModels.Search.InputModels.SearchQuery	100%
SAPPub.Core.Services.EmailService	100%	100%
SAPPub.Core.Services.EstablishmentService	100%
SAPPub.Core.Services.Gateway.GatewayLocalAuthorityService	0%
SAPPub.Core.Services.Gateway.GatewaySettingsService	0%
SAPPub.Core.Services.Gateway.GatewayUserAuditService	0%
SAPPub.Core.Services.Gateway.GatewayUserLAService	0%
SAPPub.Core.Services.Gateway.GatewayUserService	0%
SAPPub.Core.Services.KS4.Absence.EnglandAbsenceService	100%
SAPPub.Core.Services.KS4.Absence.EstablishmentAbsenceService	100%
SAPPub.Core.Services.KS4.Absence.LAAbsenceService	100%
SAPPub.Core.Services.KS4.Attendance.AttendanceService	100%	100%
SAPPub.Core.Services.KS4.Destinations.EnglandDestinationsService	100%
SAPPub.Core.Services.KS4.Destinations.EstablishmentDestinationsService	100%
SAPPub.Core.Services.KS4.Destinations.LADestinationsService	100%
SAPPub.Core.Services.KS4.DestinationsService	0%
SAPPub.Core.Services.KS4.Performance.EnglandPerformanceService	100%
SAPPub.Core.Services.KS4.Performance.EnglishAndMathsResultsService	100%
SAPPub.Core.Services.KS4.Performance.EstablishmentPerformanceService	100%
SAPPub.Core.Services.KS4.Performance.LAPerformanceService	100%
SAPPub.Core.Services.KS4.SubjectEntries.EstablishmentSubjectEntriesService	100%
SAPPub.Core.Services.KS4.Workforce.EstablishmentWorkforceService	100%
SAPPub.Core.Services.MySchoolsListService	94.5%	100%
SAPPub.Core.Services.Search.FeatureFlagSearchVisibilityPolicy	0%
SAPPub.Core.ValueObjects.CodedDouble	0%

SAPPub.Infrastructure - 62.5%

Name	Line	Branch
SAPPub.Infrastructure	62.5%	31.8%
SAPPub.Infrastructure.Mapping.ValueCodes.CodedDoubleTypeHandler	9%	0%
SAPPub.Infrastructure.Mapping.ValueCodes.ReasonCodeLookup	50%
SAPPub.Infrastructure.Mapping.ValueCodes.ReflectionCodedValueMapper	0%	0%
SAPPub.Infrastructure.Mapping.ValueCodes.ValueCodeParser	0%	0%
SAPPub.Infrastructure.PostcodeLookup.PostcodeLookupService	100%
SAPPub.Infrastructure.PostgresSearch.PostgresSchoolSearchIndexReader	100%
SAPPub.Infrastructure.Repositories.EmailRepository	94.1%
SAPPub.Infrastructure.Repositories.EstablishmentRepository	100%	100%
SAPPub.Infrastructure.Repositories.Gateway.GatewayLocalAuthorityRepository	100%	100%
SAPPub.Infrastructure.Repositories.Gateway.GatewayUserAuditRepository	100%
SAPPub.Infrastructure.Repositories.Gateway.GatewayUserRepository	100%
SAPPub.Infrastructure.Repositories.Generic.DapperCommandBuilder	0%	0%
SAPPub.Infrastructure.Repositories.Generic.DapperRepository`1	90%	100%
SAPPub.Infrastructure.Repositories.Generic.JSONRepository`1	0%	0%
SAPPub.Infrastructure.Repositories.Helpers.DapperHelpers	70.8%	11.1%
SAPPub.Infrastructure.Repositories.KS4.Absence.EnglandAbsenceRepository	100%
SAPPub.Infrastructure.Repositories.KS4.Absence.EstablishmentAbsenceReposito ry	100%
SAPPub.Infrastructure.Repositories.KS4.Absence.LAAbsenceRepository	100%
SAPPub.Infrastructure.Repositories.KS4.Destinations.EnglandDestinationsRepo sitory	100%
SAPPub.Infrastructure.Repositories.KS4.Destinations.EstablishmentDestinatio nsRepository	100%
SAPPub.Infrastructure.Repositories.KS4.Destinations.LADestinationsRepositor y	100%
SAPPub.Infrastructure.Repositories.KS4.Performance.EnglandPerformanceReposi tory	100%
SAPPub.Infrastructure.Repositories.KS4.Performance.EstablishmentPerformance Repository	100%
SAPPub.Infrastructure.Repositories.KS4.Performance.LAPerformanceRepository	100%
SAPPub.Infrastructure.Repositories.KS4.SubjectEntries.EstablishmentSubjectE ntriesRepository	100%
SAPPub.Infrastructure.Repositories.KS4.Workforce.EstablishmentWorkforceRepo sitory	100%
SAPPub.Infrastructure.Repositories.LaUrlsRepository	100%

SAPPub.Web - 87%

Name	Line	Branch
SAPPub.Web	87%	88.6%
SAPPub.Web.Areas.Compare.Filters.SecondaryComparisonQueryValidationAttribut e	100%
SAPPub.Web.Areas.Compare.ViewModels.Secondary.CompareSecondarySchoolBaseVie wModel	100%
SAPPub.Web.Areas.Gateway.Controllers.GatewayController	53%	50%
SAPPub.Web.Constants.Constants	100%
SAPPub.Web.Controllers.CookiesController	90.4%	100%
SAPPub.Web.Controllers.ErrorController	82.3%	100%
SAPPub.Web.Controllers.HealthController	67.5%	100%
SAPPub.Web.Controllers.HelpController	100%
SAPPub.Web.Controllers.HomeController	100%
SAPPub.Web.Controllers.MySchoolsController	100%	100%
SAPPub.Web.Controllers.MySchoolsListController	100%	100%
SAPPub.Web.Controllers.SchoolController	0%
SAPPub.Web.Controllers.SearchController	100%	100%
SAPPub.Web.Controllers.SecondarySchoolController	100%
SAPPub.Web.Helpers.CommonHelper	100%	100%
SAPPub.Web.Helpers.DisplayField`1	93.7%
SAPPub.Web.Helpers.DisplayFieldExtensions	100%	100%
SAPPub.Web.Helpers.EnumHelper	100%
SAPPub.Web.Helpers.TempDataHelper	91.6%	100%
SAPPub.Web.Helpers.UrlHelper	100%	100%
SAPPub.Web.Middleware.DependenciesExtensions	100%	100%
SAPPub.Web.Middleware.GatewayMiddleware	100%	100%
SAPPub.Web.Middleware.GatewayMiddlewareExtensions	0%
SAPPub.Web.Middleware.NotFoundExceptionHandler	50%	50%
SAPPub.Web.Middleware.SecurityHeadersMiddleware	89.1%
SAPPub.Web.Middleware.SecurityHeadersMiddlewareExtensions	100%
SAPPub.Web.Models.Common.PagerViewModel	62%	100%
SAPPub.Web.Models.Common.PaginationItem	85.7%
SAPPub.Web.Models.ErrorViewModel	0%
SAPPub.Web.Models.MySchools.MySchoolModel	100%
SAPPub.Web.Models.MySchools.MySchoolsListViewModel	100%
SAPPub.Web.Models.Search.SearchResult	100%	100%
SAPPub.Web.Models.Search.SearchResultsViewModel	100%	100%
SAPPub.Web.Models.SecondarySchool.AboutSchoolViewModel	100%	100%
SAPPub.Web.Models.SecondarySchool.AcademicPerformanceAttainmentAndProgressV iewModel	99%	100%
SAPPub.Web.Models.SecondarySchool.AcademicPerformanceEnglishAndMathsResults ViewModel	100%
SAPPub.Web.Models.SecondarySchool.AcademicPerformanceSubjectsEnteredViewMod el	100%
SAPPub.Web.Models.SecondarySchool.AdmissionsViewModel	100%	100%
SAPPub.Web.Models.SecondarySchool.AttendanceViewModel	100%
SAPPub.Web.Models.SecondarySchool.CurriculumAndExtraCurricularActivitiesVie wModel	100%
SAPPub.Web.Models.SecondarySchool.DestinationsViewModel	100%
SAPPub.Web.Models.SecondarySchool.SecondarySchoolBaseViewModel	100%
SAPPub.Web.Models.SecondarySchool.SuccessorOrPredecessorDetailsModel	100%
SAPPub.Web.ViewComponents.Banner.Banner	100%
SAPPub.Web.ViewComponents.MySchools.AddSchoolButton	100%
SAPPub.Web.ViewComponents.Pagination.Pagination	100%
SAPPub.Web.ViewComponents.VerticalNavigation.VerticalNavigation	100%
SAPPub.Web.ViewComponents.VerticalNavigation.VerticalNavigationModel	100%
SAPPub.Web.ViewComponents.VerticalNavigationCompareSecondary.VerticalNaviga tionCompareSecondary	100%
SAPPub.Web.ViewComponents.VerticalNavigationCompareSecondary.VerticalNaviga tionCompareSecondaryModel	0%	0%
SAPPub.Web.ViewComponents.VerticalNavigationMySchools.VerticalNavigationMyS chools	100%
SAPSec.Web.Setup.WebApplicationBuilderExtensions	33.8%	12.5%

github-actions · 2026-06-22T10:31:37Z

school/100273/saint-paul-roman-catholic-infant-school/secondary/destinations

https://127.0.0.1:43055/school/100273/saint-paul-roman-catholic-infant-school/secondary/destinations

Violations: 1

IMPACT: Critical

label: Form elements must have labels

Target: #current-view

Target: #data-overtime-view

school/100273/saint-paul-roman-catholic-infant-school/secondary/academic-performance-english-and-maths-results

https://127.0.0.1:43055/school/100273/saint-paul-roman-catholic-infant-school/secondary/academic-performance-english-and-maths-results

Violations: 1

IMPACT: Critical

label: Form elements must have labels

Target: #current-view

Target: #data-overtime-view

stuw-dfe added 3 commits June 18, 2026 17:03

Education Phase information added to the school profile about page

136d93d

Wording change on education phase

1de2d85

Merge branch 'main' into feature/537-add-phase-to-the-about-the-schoo…

6517eb7

…l-page

stuw-dfe added the deploy A Review App will be created for PRs with this label label Jun 22, 2026

stuw-dfe deployed to review June 22, 2026 10:18 — with GitHub Actions View deployment

CathLass approved these changes Jun 22, 2026

View reviewed changes

stuw-dfe merged commit f427e6a into main Jun 22, 2026
18 checks passed

stuw-dfe deleted the feature/537-add-phase-to-the-about-the-school-page branch June 22, 2026 12:29

stuw-dfe temporarily deployed to review June 22, 2026 12:29 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/537 add phase to the about the school page#398

Feature/537 add phase to the about the school page#398
stuw-dfe merged 3 commits into
mainfrom
feature/537-add-phase-to-the-about-the-school-page

stuw-dfe commented Jun 22, 2026

Uh oh!

github-actions Bot commented Jun 22, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 22, 2026

Uh oh!

github-actions Bot commented Jun 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

stuw-dfe commented Jun 22, 2026

Description

How Has This Been Tested?

Uh oh!

github-actions Bot commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 22, 2026

Summary

Coverage

Uh oh!

github-actions Bot commented Jun 22, 2026

school/100273/saint-paul-roman-catholic-infant-school/secondary/destinations

school/100273/saint-paul-roman-catholic-infant-school/secondary/academic-performance-english-and-maths-results

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Jun 22, 2026 •

edited

Loading