Skip to content

feat(2689): add review app reconcile workflow#610

Open
pasitconsulting wants to merge 1 commit into
mainfrom
2689-check-delete-review-app
Open

feat(2689): add review app reconcile workflow#610
pasitconsulting wants to merge 1 commit into
mainfrom
2689-check-delete-review-app

Conversation

@pasitconsulting

Copy link
Copy Markdown
Contributor

Context

  • to add review app housekeeping/reconciliation workflow for new tenants

https://trello.com/c/224583KN/2689-check-delete-review-app

Changes proposed in this pull request

  • addition of new workflow - reconcile review apps

Checklist

  • I have performed a self-review of my code, including formatting and typos
  • I have cleaned the commit history
  • I have added the Devops label
  • I have attached the pull request to the trello card

resource-group-name: ${{ env.RESOURCE_GROUP_NAME }}
storage-account-name: ${{ env.STORAGE_ACCOUNT_NAME }}
container-name: ${{ env.CONTAINER_NAME }}
tf-state-file: review-${{ matrix.pr_number }}_kubernetes.tfstate No newline at end of file

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should match the format from delete-review-app.yml if possible,
e.g
resource-group-name: "${{ env.AZURE_RESOURCE_PREFIX }}-#SERVICE_SHORT#-${{ env.CONFIG_SHORT }}-rg"
storage-account-name: "${{ env.AZURE_RESOURCE_PREFIX }}#SERVICE_SHORT#${{ env.CONFIG_SHORT }}tfsa"
tf-state-file: "${{ env.ENVIRONMENT }}_kubernetes.tfstate"
which could be added to the above steps aswell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants