Add storage account queue support#197
Merged
Merged
Conversation
RMcVelia
reviewed
Jun 8, 2026
| } | ||
|
|
||
| resource "azurerm_private_endpoint" "storage_queue" { | ||
| count = var.use_private_storage ? 1 : 0 |
Contributor
There was a problem hiding this comment.
This will always create a storage queue if private storage is enabled.
Possibly something like var_use_private_storage true and variable queues is not []
This would have to be added to data and output vars too.
Contributor
Author
There was a problem hiding this comment.
Good point. I've updated the count condition across resources.tf, data.tf and outputs.tf so the queue private endpoint is only created when use_private_storage is true and var.queues is not empty.
RMcVelia
reviewed
Jun 9, 2026
|
|
||
| output "storage_private_blob_fqdn" { | ||
| value = var.use_private_storage ? "${azurerm_storage_account.main.name}.privatelink.blob.core.windows.net" : null | ||
| } |
Contributor
There was a problem hiding this comment.
I think we also need to output the primary_queue_endpoint similar to the primary_blob_endpoint
Contributor
Author
There was a problem hiding this comment.
I have added primary_queue_endpoint output to mirror as suggested
98112d7 to
697fd3f
Compare
RMcVelia
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
CYPD want to use Storage Account queues but the module only supported blob storage. This adds queue support with its own private endpoint, DNS zone wiring and outputs so consuming services can start using queues privately.
Changes proposed in this pull request
Four files touched in aks/storage_account:
Guidance to review
Before merging
After merging
Checklist
Devopslabel