Add Salesforce symbol indexing#9
Conversation
| if (language === 'proto') return extractProto(content, filePath).symbols | ||
| if (language === 'powershell') return extractPowershell(content, filePath).symbols | ||
| if (language === 'apex') return extractApex(content, filePath).symbols | ||
| if (language === 'salesforce_metadata') { |
There was a problem hiding this comment.
Why is this one not a one-liner, like the rest?
| go: 'a.go', | ||
| c: 'a.c', | ||
| cpp: 'a.cpp', | ||
| ruby: 'a.rb', |
There was a problem hiding this comment.
Why is this added here? Are those changes related to Salesforce?
708becf to
956b72e
Compare
|
Thanks for this, Krzysztof. Apex and Salesforce metadata were a real gap here, and the implementation shows it: On your question about Also saw you already fixed the one-liner style issue in One small non-blocking nit: in Ready to merge from here. Thanks for the careful work, and for flagging what you weren't sure about instead of guessing. |
956b72e to
66d3484
Compare
|
Hi @Zelys-DFKH, sorry, this PR was in draft staus, I was actively working on it, and those questions were directed to my Codex :D Code from this PR has some holes, especially for profiles, where whole profiles are getting indexed, which makes no sense. In a moment I'll open a full pull request with a fix for that and tests fully performed ;) EDIT: no, my bad, I pushed profile-related changes to this PR, so we're fine with that. However, I opened another pull request anyway, with extension of handled salesforce metadata, inluding LWC components. |
Summary:
Verification: