fix(rust_brain): preserve HLC on snapshot restore and gossip receive#36
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(rust_brain): preserve HLC on snapshot restore and gossip receive#36cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
restore_from_file() dropped hlc fields from snapshots, assigning fresh process-local HLCs instead. After disaster recovery, causal successor writes from the original writer were rejected with TimestampRegression, and gossip without HLC could overwrite fresher data. - Add _parse_hlc() for snapshot/wire normalisation - Restore hlc per node and advance global _hlc during restore - Pass hlc through bulk_write when present - Gossip receive: apply HLC, reject stale updates, skip missing-HLC overwrites - Hold lock during restore and gc_expired - Regression tests for restore round-trip and gossip HLC ordering Co-authored-by: Daniel <DJLougen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
restore_from_file()droppedhlcfields from v0.6.0 snapshots, assigning fresh process-local HLCs instead. After disaster recovery:TimestampRegression→ silent data loss for replayed/gossiped updatesRoot cause
HLC was added in v0.6.0 for monotonic causal ordering, but
restore_from_file()andgossip.receive()never restored/applied stored HLCs.bulk_write()also omitted HLC passthrough.Fix
_parse_hlc()for snapshot/wire normalisation (with legacy fallback fromts_ns)hlcper node and advance global_hlcduring restorehlcthroughbulk_writewhen presentgc_expiredValidation
Reproduced on main: restore assigned
(wall, 0, uuid)instead of snapshot(5000, 10, "nodeA"); successor write raisedTimestampRegression.After fix:
192 passed, 8 skipped(full suite). New regression tests intest_enterprise_backup.pyandtest_gossip.py.