Remove all terraform=true hardcoded tags

[lucasmacedot]

Terraform errors if the default_tags block have the same tag as the tags on a resource.
A better way to manage this is to put all tags on the default_tags block, and pass tags specific to modules on the tags variable

Types of changes

What types of changes does your code introduce to <repo_name>?
Put an x in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

• I have read the CONTRIBUTING.md doc.
• I have added necessary documentation (if appropriate).
• Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

[Renatovnctavares]

which terraform version comes with the default_tags - can we make it retro-compatible?
leaving tags variable defined and we can send an empty value in case it is needed

is it worth?

variable "tags" {
description = "Map of tags that will be added to created resources. By default resources will be tagged with terraform=true."
type = map(string)
default = {
"Terraform" = true
}
}

@adenot what do you think?

[adenot]

which terraform version comes with the default_tags - can we make it retro-compatible? leaving tags variable defined and we can send an empty value in case it is needed

is it worth?

variable "tags" { description = "Map of tags that will be added to created resources. By default resources will be tagged with terraform=true." type = map(string) default = { "Terraform" = true } }

@adenot what do you think?

yes, adding the default for tags as the existing tag (terraform=true) will avoid some unnecessary drift

[lucasmacedot]

@adenot @Renatovnctavares done, can you review again?