fix two validate database checks that never ran - #139
Open
dereklichtner wants to merge 1 commit into
Open
dereklichtner wants to merge 1 commit into
dereklichtner wants to merge 1 commit into
Conversation
compare_sr read obj1 twice instead of obj2; metadata check used .exists without parens so it was always truthy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two checks in
GeMS_ValidateDatabase.pynever actually ran. Checks would always pass even if dataset was not correct.compare_sr()meant to flag when two feature classes use different spatial references but it was reading both spatial refs from the first feature class:So it always compared a feature class to itself and never reported a mismatch.
Also, metadata check used
Path(metadata_file).existsie the method itself. "Does not exist" branch would never run andvalidate_w_mp()was passed missing file. Now calls.exists()with parenthesesVerified with ArcGIS Pro 3.6.1 with WSGS GeMS gdbs.
The affected lines are the same on
masterandVersion-3.