Skip to content

Isolate caller-supplied metadata with deepcopy #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pnorton-usgs merged 1 commit into from
Aug 17, 2026
Merged

Isolate caller-supplied metadata with deepcopy #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions pyPRMS/parameters/Parameters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,15 @@ def __init__(self, metadata: MetaDataType,
con = get_console_instance()
# con.print('Parameters: Console info: {}'.format(con))

# A full, separate copy of the original metadata dictionary
# A pristine deep copy of the original metadata, never mutated.
# Used by create_subset() to build new Parameters instances.
self.__full_metadata = deepcopy(metadata)

self.__dimensions = deepcopy(Dimensions(metadata=metadata, verbose=verbose))
# A separate working copy that this instance is free to mutate
# (e.g. bounded resolution, dimension size changes).
_working_metadata = deepcopy(metadata)

self.__dimensions = Dimensions(metadata=_working_metadata, verbose=verbose)
self.__parameters: dict[str, Parameter] = dict()

self.verbose = verbose
Expand All @@ -82,8 +87,8 @@ def __init__(self, metadata: MetaDataType,
self.__seg_shape_key: str | None = None
self.__seg_to_hru: dict[int, list[int]] = dict()
self.__hru_to_seg: dict[int, int] = dict()
self.metadata = metadata['parameters']
self.prms_version = Version(metadata['info']['version'])
self.metadata = _working_metadata['parameters']
self.prms_version = Version(_working_metadata['info']['version'])

def __contains__(self, name: str) -> bool:
"""Check if a parameter exists.
Expand Down