Skip to content

Fix DPDBaltics sidebar item disappearing on module pages - #167

Merged
rokaszygmantas merged 1 commit into
DPDBaltics:release-3.3.1from
TLabutis:BUGFIX/sidebar-menu-disappears-on-dpd-pages
May 25, 2026
Merged

Fix DPDBaltics sidebar item disappearing on module pages#167
rokaszygmantas merged 1 commit into
DPDBaltics:release-3.3.1from
TLabutis:BUGFIX/sidebar-menu-disappears-on-dpd-pages

Conversation

@TLabutis

@TLabutis TLabutis commented May 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • views/css/admin/global_module.css had a rule #subtab-AdminDPDBalticsModule { display: none } that hid the entire <li> wrapping the DPDBaltics sidebar link, not just nested children.
  • This CSS is loaded by AbstractAdminController::setMedia() on every DPDBaltics admin controller, so the DPDBaltics navigation item vanished from the sidebar whenever a user opened any DPDBaltics page (Shipment, Courier request, etc.).
  • Replaced with a narrower selector that targets only nested submenu elements, keeping the parent link visible.

Test plan

  • Reproduced bug on PS 1.7.8.9: navigated to AdminDPDBalticsShipment, confirmed #subtab-AdminDPDBalticsModule had display: none via DOM inspection.
  • Applied fix and verified #subtab-AdminDPDBalticsModule now renders with display: block and the link is visually present in the sidebar (screenshot).
  • Verified no regression on PS core controllers (AdminCarriers, AdminDashboard): DPDBaltics still appears in sidebar as before.
  • Verified top tab strip on the page (#head_tabs) still renders all 10 child tabs (Shipment, Orders returns, Courier request, Addresses, etc.).
  • Verify same fix on PS 8.x and PS 9.x.

CSS rule #subtab-AdminDPDBalticsModule { display: none } hid the
entire <li> wrapping the sidebar link, so the DPDBaltics entry
vanished whenever a DPDBaltics admin controller loaded
global_module.css. Refined selector targets only nested submenu
elements, keeping the parent link visible.
@rokaszygmantas
rokaszygmantas merged commit 36236be into DPDBaltics:release-3.3.1 May 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants