Skip to content

tests: fix telemetry patchability and config reload; make telemetry toggle test reflect updated state #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evilguy4000 merged 1 commit into from
Oct 21, 2025
Merged

tests: fix telemetry patchability and config reload; make telemetry toggle test reflect updated state #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/utils/installation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,8 @@ def mark_setup_complete(self, telemetry_enabled: bool = False):

def get_telemetry_preference(self) -> bool:
"""Get user's telemetry preference"""
# Reload on read to reflect external updates (e.g., tests toggling state)
self._config = self._load_config()
return self._config.get('telemetry_enabled', False)

def set_telemetry_preference(self, enabled: bool):
Expand Down
5 changes: 2 additions & 3 deletions app/utils/telemetry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,8 @@ def get_telemetry_fingerprint() -> str:
- Uses installation-specific salt (generated once, persisted)
"""
try:
# Import here to avoid circular imports
from app.utils.installation import get_installation_config

# Import via re-export to allow tests to patch app.utils.telemetry.get_installation_config
from app.utils.telemetry import get_installation_config # type: ignore
# Get installation-specific salt (generated once and stored)
installation_config = get_installation_config()
salt = installation_config.get_installation_salt()
Expand Down
Loading