Develop - #305
Merged
Merged
Develop#305
Conversation
…se browser compatibility warnings ServiceWorker was incorrectly treated as a required feature, causing browser compatibility warnings to appear on every page load/refresh when accessing the app over HTTP (common in Portainer setups without HTTPS). Changes: - Removed serviceWorker from required features check (it's a PWA enhancement, not core functionality) - Only localStorage and fetch are now checked as truly required features - Added debug logging for serviceWorker availability without showing user-facing warnings - App now works normally over HTTP without serviceWorker, only missing optional PWA features
- Fix incorrect relationship name: Comment.user -> Comment.author The Comment model uses 'author' relationship, not 'user' - Fix eager loading of dynamic relationships Remove invalid eager loading attempts for Task.activities and Task.time_entries, which are dynamic relationships (lazy='dynamic') and cannot be eager loaded with joinedload() - Query dynamic relationships correctly Update task view route to properly query time_entries and activities using their dynamic relationship query objects, with proper eager loading of nested relationships (TimeEntry.user, TaskActivity.user) to prevent N+1 queries Fixes issue where task detail view returned HTTP 500 error after creating a new task.
Add support for four authentication modes via AUTH_METHOD environment variable: - none: Username-only authentication (no password) - local: Password authentication required (default) - oidc: OIDC/Single Sign-On only - both: OIDC + local password authentication Key changes: - Add password_hash column to users table (migration 068) - Implement password storage and verification in User model - Update login routes to handle all authentication modes - Add conditional password fields in login templates - Support password authentication in kiosk mode - Allow password changes in user profile when enabled Password authentication is now enabled by default for better security, while remaining backward compatible with existing installations. Users will be prompted to set passwords when required. Fixes authentication bypass issue where users could access accounts without passwords even after setting them.
Implement a configuration management system where settings changed via WebUI take priority over .env values, while .env values are used as initial startup values. Changes: - Update ConfigManager.get_setting() to check Settings model first, then environment variables, ensuring WebUI changes have highest priority - Add Settings._initialize_from_env() method to initialize new Settings instances from .env file values on first creation - Update Settings.get_settings() to automatically initialize from .env when creating a new Settings instance - Add Settings initialization in create_app() to ensure .env values are loaded on application startup - Add comprehensive test suite (test_config_priority.py) covering: * Settings priority over environment variables * .env values used as initial startup values * WebUI changes persisting and taking priority * Proper type handling for different setting types This ensures that: 1. .env file values are used as initial configuration on first startup 2. Settings changed via WebUI are saved to database and take priority 3. Configuration priority order: Settings (DB) > .env > app config > defaults Fixes configuration management workflow where users can set initial values in .env but override them permanently via WebUI without modifying .env.
Database Migration Validation✅ Migration validation passed! Completed checks:
The database migrations are safe to apply. 🚀 📝 Note: Schema drift warnings indicate existing model/migration mismatches that existed before this PR. These should be addressed in a separate schema alignment PR. This comment was automatically generated by the Migration Validation workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.