Develop - #448
Merged
Merged
Develop#448
Conversation
…uploads, currency) - custom_field_definitions: capture definition_id before delete and use it in safe_commit to avoid touching detached definition; in tests re-query Client by id after request instead of db.session.refresh() to avoid 'not persistent' - permissions: test_delete_role_flow asserts by name (deletable_role) instead of Role.query.get(role_id) so redirect-triggered sync_permissions_and_roles id reuse does not cause false failure - uploads: add password to authenticated_admin_client login_data in test_uploads_persistence so login succeeds and logo upload tests see company_logo_filename - currency_display: run PRAGMAs only for file-based SQLite and use text(); skip for in-memory sqlite:// to avoid ResourceClosedError in admin_user fixture during commit
The logout route uses current_app.config for AUTH_METHOD and Config for OIDC_POST_LOGOUT_REDIRECT_URI. Two tests only patched Config, so auth_method stayed local and the handler never hit the IdP redirect branch, causing redirects to /login and assertion failures. Set app.config AUTH_METHOD to oidc in test_logout_with_post_logout_uri_config and test_logout_oidc_provider_has_revocation_endpoint_only so the route enters the OIDC branch and the tests pass.
- test_client_portal_dashboard_requires_access: expect 302 redirect to client portal login instead of 403. The client portal 403 handler redirects authenticated non-portal users to login by design. - Run routes unit group with -n 0 in CI to avoid SQLite 'database is locked' errors from audit logging under pytest-xdist parallel workers; fixes client_portal and admin client-portal test failures.
…oader test - Add cascade='all, delete-orphan' to the notes backref so client notes are removed when a client is deleted. - In test_client_has_notes_relationship use client.notes.count() instead of len(client.notes) since the backref uses lazy='dynamic'.
Database Migration Validation✅ Migration validation passed! Completed checks:
The database migrations are safe to apply. 🚀 📝 Note: Schema drift warnings indicate existing model/migration mismatches that existed before this PR. These should be addressed in a separate schema alignment PR. This comment was automatically generated by the Migration Validation workflow. |
❌ CI Test ResultsOverall Status: 2 test suite(s) failed Test Results: 3/7 passed Test Suites:
Commit: eda084a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.