Develop - #449
Merged
Merged
Develop#449
Conversation
…te in tests - Client: call flag_modified() after mutating custom_fields in set_custom_field() and remove_custom_field() so SQLAlchemy persists JSON changes (in-place dict updates are not tracked by default). Fixes test_count_clients_with_value_ignores_empty and test_count_clients_with_value_ignores_other_fields. - ClientNote: add ondelete=CASCADE to client_id FK so schema from db.create_all() matches migration 024 and notes are deleted when client is deleted. Fixes test_client_note_cascade_delete.
…flush) - Make InstallationConfig config dir overridable via INSTALLATION_CONFIG_DIR so tests and CI use a writable path instead of /data (fixes PermissionError on redirect to /admin/settings after logo upload). - Set INSTALLATION_CONFIG_DIR in conftest before app import and in ci-comprehensive.yml for integration-tests and full-test-suite jobs. - In Settings.get_settings(), add _session_in_flush() and a re-entrancy guard to skip add+commit when called during another commit's flush, fixing ResourceClosedError in currency_display test setup. - Update test_installation_config fixture to set INSTALLATION_CONFIG_DIR so it continues to use its temp dir with the new env-based behavior.
Database Migration Validation✅ Migration validation passed! Completed checks:
The database migrations are safe to apply. 🚀 📝 Note: Schema drift warnings indicate existing model/migration mismatches that existed before this PR. These should be addressed in a separate schema alignment PR. This comment was automatically generated by the Migration Validation workflow. |
❌ CI Test ResultsOverall Status: 2 test suite(s) failed Test Results: 3/7 passed Test Suites:
Commit: 54bf6c8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.