[NDH-324] Amendments to Fixtures and Test cases

[IsaacMilarky]

Amendments to Fixtures and Test cases

Jira Ticket #NDH-324

Problem

The current state of the amended test fixtures is not quite to specification for ticket NDH-324. Also, the fixtures file is getting to be very large and needs to be turned into a module of separate files.

Solution

Amend the test cases to check all returned data and make sure that we aren't getting back data that was not supposed to be fetched by the given filter parameter. Also, improve the tests by adding additional fixture data that adds a non NPI identifier. Additionally, improve the test cases by making sure all assertions match the filters.

I have also created a new fixtures module to replace the fixtures.py file because it was getting to be pretty large.

Result

Summary:

• Amend test cases to check all results
• Amend fixture data to create a practitioner with a non NPI identifier
• Amend address test case to test for a more specific search parameter than "Street"
• Test that the address part of the returned data includes use data
• Amend test case to check the 'use' field instead of other identifying data
• Edit test data fixture to have multiple codes

The amended tests have also exposed some issues in the code-base. Namely, the test that checks to see if the identifier filter can fetch non NPI identifiers does not find that identifier in the returned data. I think this is because the non NPI identifier is just not present in the serialized data although the correct record does appear to be fetched.

Additionally, the tests have also found that the 'use' field is missing from the returned practitioner data address field.

I also ran make format so there have been a bunch of formatting changes from ruff.

[github-actions]

Backend Django Test Results

98 tests  ±0   96 ✅  - 2   1s ⏱️ ±0s
13 suites ±0    0 💤 ±0 
13 files   ±0    2 ❌ +2 

For more details on these failures, see this check.

Results for commit 81cd86c. ± Comparison against base commit 7aac220.

♻️ This comment has been updated with latest results.

[spopelka-dsac]

It looks like the broken address_sue test is specifically a problem with how this line is trying to identify whether an address use is present:

npd/backend/npdfhir/serializers.py

Line 85 in 3333620

if "use" in representation.keys():

Can you please fix that line so that the test_list_filter_by_address_use test will pass?

The test_list_filter_by_npi_general failure is a result of the test needing to be updated, as I noted in my comment on the test.

[spopelka-dsac]

Do you need to get the associated object first? I think you should be able to just pass "prod" as the value in for environment_type in line 64. Same for the other areas where you're querying first

[IsaacMilarky]

I get a ValueError when I try to just pass in a string

[spopelka-dsac]

Can you say more about the behavior you were experiencing that necessitated these ensure functions?

[IsaacMilarky]

It was a while ago but I think I did that because in the reference data sql file it inserts the endpoint_connection_type data in the reference data but it doesn't insert anything for the endpoint_type data. I wanted to make sure that it would handle if that data was added in the reference data sql file.

[spopelka-dsac]

It would be helpful to create non-nurse practitioners as well, so we can ensure that there are some test practitioners in the test dataset that aren't nurses

[IsaacMilarky]

Sounds good I created a couple records for people that have other nucc classifications.