Skip to content

fix(evm): reduce account access of extcodecopy in interpreter #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zoowii merged 1 commit into from
Jan 28, 2026
Merged

fix(evm): reduce account access of extcodecopy in interpreter #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions src/evm/opcode_handlers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,18 +597,10 @@ void ExtCodeCopyHandler::doExecute() {
Frame->Msg.gas -= ADDITIONAL_COLD_ACCOUNT_ACCESS_COST;
}

size_t CodeSize = Frame->Host->get_code_size(Addr);

if (Offset >= CodeSize) {
// If Offset is beyond the code size, fill with zeros
if (Size > 0) {
std::memset(Frame->Memory.data() + DestOffset, 0, Size);
}
} else {
if (Size > 0) {
// Copy code to memory
auto CopySize = std::min(Size, CodeSize - Offset);
size_t CopiedSize = Frame->Host->copy_code(
Addr, Offset, Frame->Memory.data() + DestOffset, CopySize);
Addr, Offset, Frame->Memory.data() + DestOffset, Size);
if (CopiedSize < Size) {
// If the copied size is less than requested, fill the rest with zeros
std::memset(Frame->Memory.data() + DestOffset + CopiedSize, 0,
Expand Down
4 changes: 4 additions & 0 deletions tests/evmone_unittests/EVMOneInterpreterUnitTestsRunList.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,3 +209,7 @@ multi_vm/evm.exp/external_vm
multi_vm/evm.exp_oog/external_vm
multi_vm/evm.exp_pre_spurious_dragon/external_vm
multi_vm/evm.shift_overflow/external_vm
multi_vm/evm.eip2929_case2/external_vm
multi_vm/evm.extcode/external_vm
multi_vm/evm.extcodecopy_nonzero_index/external_vm
multi_vm/evm.extcodecopy_fill_tail/external_vm