ci: enforce change document declarations - #581
Closed
abmcar wants to merge 2 commits into
Closed
Conversation
# Conflicts: # docs/changes/README.md
⚡ Performance Regression Check Results✅ Performance Check Passed (interpreter)Performance Benchmark Results (threshold: 25%)
Summary: 194 benchmarks, 0 regressions ✅ Performance Check Passed (multipass)Performance Benchmark Results (threshold: 25%)
Summary: 193 benchmarks, 0 regressions |
This was referenced Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?
2. Scope
Development workflow, change-proposal policy, pull request template,
contribution tooling, and CI.
3. Description
This change requires every pull request to provide either a governing
change-document path or a specific
N/Areason. It aligns the agent workflowand change-proposal guide on a closed exemption set, broadens
dev-workflowbeyond features, and defines the exact
Proposed→Accepted→Implementedtransition points.
The root cause was a contradictory entry policy: agent guidance let simple bug
fixes skip proposal work while
docs/changes/README.mdrequired Light documentsfor bug fixes with design implications. The PR template and CI had no final
declaration check, so that contradiction could reach review without a signal.
The new validator checks declaration syntax, rejects placeholder exemptions,
and verifies a referenced document at the PR head. It deliberately does not
infer policy from
src/**; reviewers retain control over explicit exemptions.4. Breaking changes
5. Tests
Validation completed:
Change docandN/Aformsgit diff --checkdtvmapibuilddtvm_local_test.sh --autoselected multipass evmone unit and state tests forthe mixed tooling/CI paths, but its preflight stopped because the local evmone
binaries and EEST fixtures are not installed. No runtime source changed; the
missing suite is recorded in the change document.
6. Change document
Change doc: docs/changes/2026-07-28-enforce-change-document-declaration/README.md
7. Release note