Skip to content

Feat: Implements Job registry and get bids view function#221

Merged
soomtochukwu merged 5 commits into
DXmakers:mainfrom
devfoma:Feat/implement-jobregistry-getbids-view-functions
Apr 22, 2026
Merged

Feat: Implements Job registry and get bids view function#221
soomtochukwu merged 5 commits into
DXmakers:mainfrom
devfoma:Feat/implement-jobregistry-getbids-view-functions

Conversation

@devfoma
Copy link
Copy Markdown
Contributor

@devfoma devfoma commented Apr 22, 2026

Summary

This pr closes #83

  • Implemented production-ready get_job and get_bids view functions in the JobRegistry contract with graceful error handling.
  • Transitioned get_job and get_bids to return Result<T, JobRegistryError>, replacing panics and minimal defaults with standard Soroban error codes.
  • Updated the Reputation contract's cross-contract invocation logic to maintain compatibility with the new JobRegistry return types.
  • Provided comprehensive technical documentation for the new view functions in the /docs folder and internal docstrings.

Testing

  • Unit tests updated across job_registry to handle Result types and ensure 90%+ coverage.
  • New test cases added to verify JobNotFound error states for both get_job and get_bids.
  • Cross-contract call logic verified via code review in the reputation contract.

Checklist

  • Linked issue or backlog item (Implement JobRegistry::get_job and get_bids view functions)
  • Contract behavior and invariants are described clearly
  • Docs updated if contract interfaces or workflows changed
  • Scope stays limited to one contract concern (View function implementation)

@devfoma devfoma requested a review from soomtochukwu as a code owner April 22, 2026 21:44
@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented Apr 22, 2026

@devfoma Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@soomtochukwu soomtochukwu merged commit 594dc98 into DXmakers:main Apr 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement JobRegistry::get_job and get_bids view functions

2 participants