Sc reg 032 ipfs cid validations#596
Merged
soomtochukwu merged 16 commits intoMay 28, 2026
Merged
Conversation
|
@sweetesty is attempting to deploy a commit to the mAzI's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@sweetesty Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…sted profiles metrics layout
…ckup with ipfs validations and upstream features
…nly resolve conflicts
…d compilation errors
…milestone tracking, and dispute resolution logic
…ntract verification and build
…ing, and collateral management
soomtochukwu
requested changes
May 28, 2026
Contributor
soomtochukwu
left a comment
There was a problem hiding this comment.
If you could just fix the merge conflicts ASAP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #386
This PR implements Enforce Job Description IPFS CID String Format Validations inside
contracts/job_registry/src/lib.rsas specified in SC-REG-032.What was done:
Qm...base58 and CIDv1bafy...base32) before any on-chain write; invalid formats are rejected with a typedInvalidCIDerror codeDataKey::Bids(job_id)→Map<Address, Bytes>storage layout from the previous step, mapping freelancer addresses to their IPFS proposal hashesOpen → Bidding → Assignedon bid acceptance; invalid transitions are rejected with specific error variantschecked_add,checked_sub) to prevent overflow/underflowcargo testsuite covering valid CIDv0/CIDv1 inputs, malformed CID rejections, ownership violations, late bids, and full state transition flowsAcceptance criteria met:
Assignedon successful bid acceptance