Skip to content

feat(SC-ESC-020): add happy-path integration tests, getters, and chec…#646

Merged
soomtochukwu merged 1 commit into
DXmakers:mainfrom
extolkom:feat/sc-esc-020-escrow-integration-tests
May 29, 2026
Merged

feat(SC-ESC-020): add happy-path integration tests, getters, and chec…#646
soomtochukwu merged 1 commit into
DXmakers:mainfrom
extolkom:feat/sc-esc-020-escrow-integration-tests

Conversation

@extolkom
Copy link
Copy Markdown
Contributor

closes #374

Summary
Implements comprehensive happy-path integration tests for the escrow smart contract as part of the Lance marketplace ecosystem.
Changes

Fixed release_milestone panic message to "only client can release" for proper auth error signaling
Added get_escrow_balance getter to query remaining funds from persistent storage
Added get_milestone getter to query individual milestone parameters
Rewrote reentrancy guard tests to be deterministic and race-condition free
Added test_get_escrow_balance_decreases_on_release integration test
Added test_multiple_jobs_isolated integration test
Audited and completed all checked arithmetic using checked_add and checked_mul

Requirements Checklist

Storage keys and traits in contracts/escrow/src/lib.rs analyzed
Checked arithmetic (checked_add, checked_mul) applied throughout
env.require_auth enforced on all state-modifying actions
Public getter functions exposed for escrow parameters and balances

Acceptance Criteria

Contract compiles to WASM target
All test suites pass with zero gas-limit violations
Unauthorized state changes yield auth erro

@extolkom extolkom requested a review from soomtochukwu as a code owner May 29, 2026 12:17
@vercel
Copy link
Copy Markdown

vercel Bot commented May 29, 2026

@extolkom is attempting to deploy a commit to the mAzI's projects Team on Vercel.

A member of the Team first needs to authorize it.

@soomtochukwu soomtochukwu merged commit 11c1e8b into DXmakers:main May 29, 2026
2 of 8 checks passed
@extolkom extolkom deleted the feat/sc-esc-020-escrow-integration-tests branch May 29, 2026 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SC-ESC-020] Escrow System Optimization and Validation Checkpoint - Step 20

2 participants