feat(SC-ESC-020): add happy-path integration tests, getters, and chec…#646
Merged
soomtochukwu merged 1 commit intoMay 29, 2026
Merged
Conversation
|
@extolkom is attempting to deploy a commit to the mAzI's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #374
Summary
Implements comprehensive happy-path integration tests for the escrow smart contract as part of the Lance marketplace ecosystem.
Changes
Fixed release_milestone panic message to "only client can release" for proper auth error signaling
Added get_escrow_balance getter to query remaining funds from persistent storage
Added get_milestone getter to query individual milestone parameters
Rewrote reentrancy guard tests to be deterministic and race-condition free
Added test_get_escrow_balance_decreases_on_release integration test
Added test_multiple_jobs_isolated integration test
Audited and completed all checked arithmetic using checked_add and checked_mul
Requirements Checklist
Storage keys and traits in contracts/escrow/src/lib.rs analyzed
Checked arithmetic (checked_add, checked_mul) applied throughout
env.require_auth enforced on all state-modifying actions
Public getter functions exposed for escrow parameters and balances
Acceptance Criteria
Contract compiles to WASM target
All test suites pass with zero gas-limit violations
Unauthorized state changes yield auth erro