docs: clean up README, move git recovery tip to CONTRIBUTING#88
Conversation
Co-authored-by: DaTiC0 <13198638+DaTiC0@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR reorganizes user-facing documentation by simplifying setup/testing instructions in README.md and moving contributor-only git recovery guidance into CONTRIBUTING.md.
Changes:
- Reformat and de-duplicate the environment variable list and restructure the Google Service Account instructions in
README.md. - Consolidate local tunneling/testing instructions and condense the health-check section in
README.md. - Move “If You Commit to main by Mistake” from
README.mdintoCONTRIBUTING.md.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| README.md | Cleans up setup, service account, local testing, and health-check documentation. |
| CONTRIBUTING.md | Adds the git recovery workflow section intended for contributors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| The following variables are extracted automatically from that file and must also be present in your environment or `.env`: | ||
|
|
||
| To test the application locally, you can use ngrok to expose your Flask server to the internet, or you can use the cloudfare tunneling service. | ||
| - `PROJECT_ID` | ||
| - `PRIVATE_KEY_ID` | ||
| - `PRIVATE_KEY` | ||
| - `CLIENT_EMAIL` | ||
| - `CLIENT_X509_CERT_URL` |
There was a problem hiding this comment.
This paragraph says the listed variables are "extracted automatically from that file", but generate_service_account_file.generate_file() actually reads PROJECT_ID, PRIVATE_KEY_ID, PRIVATE_KEY, CLIENT_EMAIL, and CLIENT_X509_CERT_URL from the environment and merges them into the JSON loaded from SERVICE_ACCOUNT_FILE. Please reword to avoid implying they are read from the JSON file, and make it clear these env vars must be set (or adjust the code to fall back to values already present in the JSON).
| - `API_KEY` | ||
| - `AGENT_USER_ID` | ||
| - `SERVICE_ACCOUNT_FILE` | ||
| - `FIREBASE_ADMINSDK_FILE` |
There was a problem hiding this comment.
FIREBASE_ADMINSDK_FILE is listed as a required environment variable, but the codebase does not read an env var by that name (Firebase credentials come from SERVICE_ACCOUNT_DATA, which is built from SERVICE_ACCOUNT_FILE + the individual credential env vars). This entry is likely misleading and should be removed or replaced with the actual required configuration key(s).
| - `FIREBASE_ADMINSDK_FILE` | |
| - `SERVICE_ACCOUNT_DATA` |
@copilot analyze requirements and fix it |
… account flow description Co-authored-by: DaTiC0 <13198638+DaTiC0@users.noreply.github.com>
Fixed in
|
README had structural issues: duplicate env var listings, verbose testing section, vague service account instructions, and a contributor-only git tip mixed into user-facing docs.
Summary
What changed?
PROJECT_ID,PRIVATE_KEY_ID,PRIVATE_KEY,CLIENT_EMAIL,CLIENT_X509_CERT_URL) now appear once under Google Service Account with an accurate description of the runtime flowFIREBASE_ADMINSDK_FILEfrom the env var list — it is a local Python variable inapp.py, not a user-facing env varpython generate_service_account_file.pyCLI instruction — the script has no entrypoint and is only called internally byconfig.pyat startupSERVICE_ACCOUNT_FILEpoints to a JSON template; at startupgenerate_file()reads that template and overrides the 5 credential fields with values from the environment (not the other way around)curl/make healthinto one block, collapsed status-code bullets to one lineWhy was it needed?
Validation
make test)make health)AI-Assisted Review (if applicable)
Risk & Rollback
935c00cOriginal prompt
This pull request was created from Copilot chat.
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.