Conversation
Fix DLSS NR motion vector metadata handling
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix shadow flickering and shimmering in DLSS Neural Rendering when the game uses DLSS Super Resolution instead of DLAA.
Problem
The DLSS NR integration assumed that motion vectors always used the guide/render resolution and started at
(0, 0).This assumption generally went unnoticed with DLAA, where the render and output resolutions match. With DLSS SR, however, motion vectors may be provided at either render or output resolution. Passing incorrect motion vector dimensions, subrects, or scaling metadata to DLSS NR caused unstable temporal reprojection, resulting in visible shadow flickering and shimmering.
Changes
MVLowResfeature flag when determining motion vector dimensionsResult
DLSS NR now receives motion vector metadata that matches the game's actual resources and DLSS mode, fixing the shadow flickering and shimmering observed with DLSS Super Resolution while preserving DLAA behavior.
Testing