Skip to content

Conversation

@guysmoilov
Copy link
Member

No description provided.

@guysmoilov guysmoilov requested a review from kbolashev May 18, 2025 15:04
@guysmoilov guysmoilov self-assigned this May 18, 2025
@guysmoilov guysmoilov added the enhancement New feature or request label May 18, 2025
@dagshub
Copy link

dagshub bot commented May 18, 2025

Copy link
Member

@kbolashev kbolashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment on lines +51 to +56
class OAuthFlowData(NamedTuple):
"""Data object containing all necessary information for OAuth flow."""
auth_link: str
"""
The link the user needs to visit to confirm the OAuth flow.
This link should be shown to the user, who needs to open it in their web browser.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm usually using dataclasses everywhere and not named tuples, but I guess it still works so w/e

@guysmoilov guysmoilov merged commit ba4b95d into master May 21, 2025
7 of 8 checks passed
@guysmoilov guysmoilov deleted the feature/oauth-flow-decomposition branch May 21, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants