Repository navigation
Verify: only runs for this contract's round - #11
Merged
Merged
Conversation
Round numbers restart per contract and nema-dev.testnet signs for both v1 and v2, so v1's round 6 runs showed on v2's round 6 and failed the contract checks.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v1 (nema-dev.testnet) and v2 (nema-v2.testnet) both have a round 6, opened by the same account, so the Verify view listed v1's runs on v2's round 6 and showed them failing the contract checks. A run now belongs to a round only if its input names this contract. Checked on v2 round 6: round key 6/6, tally 6/6, sealed copy 5/6 (the sixth needs the reader's wallet).