fix for disable_linting appending without check#699
Open
vindolin wants to merge 1 commit intoDamnWidget:masterfrom
Open
fix for disable_linting appending without check#699vindolin wants to merge 1 commit intoDamnWidget:masterfrom
vindolin wants to merge 1 commit intoDamnWidget:masterfrom
Conversation
DamnWidget
requested changes
Sep 12, 2017
Author
|
That was my first idea but ANACONDA['DISABLED'] is a PersistentList. |
Owner
|
Yeah that's true then what do you think of moving it to the PersistentList itself into the append method (just call the append method in the super class if the element is not in the list already) and make |
Author
|
I look into this when I'm back from a vacation in about a week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running the disable_linting command multiple times, filename or
window_view gets appended to the
ANACONDA['DISABLED']/ANACONDA['DISABLED_BUFFERS'] even if it's already
there.
The user then has to run the enable_linting command the same number of
times to enable it again.
is_enabled looked for view.id() instead of (self.window.id(), view.id()).
Also I made the two files look more unified.