Adds linting messages on line hover to anaconda. Resolves #862#864
Adds linting messages on line hover to anaconda. Resolves #862#864Kyu wants to merge 2 commits intoDamnWidget:masterfrom
Conversation
DamnWidget
left a comment
DamnWidget
left a comment
There was a problem hiding this comment.
Why don't you use the anaconda_lib.Tooltip feature for this? It gives you some built-in functionality like loading themes from the css directory in the root of the project.
Kyu
force-pushed
the
issue_862
branch
2 times, most recently
from
67ae14d to
e31b2fa
Compare
|
😃
The message "undefined name 'five'" is missing, it removes messages if there are more than 3. Not sure why. Otherwise it works fine :/ |
* Created new files: templates/tooltops/error_warning.tpl and templates/tooltips/error_warning_helper.tpl
* Created new Class TooltipHelper in anaconda_lib/tooltips.py
* Created new function get_specific_lineo_msgs in anaconda_lib/linting/sublime.py
* Modified css/popup.css to add linting message color codes.
* Modified Tooltip.show_tooltip in anaconda_lib/tooltips.py to add optional **kwargs for popup
* Cleaned up listeners/linting.py, added css viewing using tooltips.py
|
Resolves #862 (Adding comment here so it is recognized bygithub) |
|
Looks good to me, anyone has any reason for this to not get merged? |
|
I'm for merging. Looks good. |
|
There’s a truncation issue, as I said in the other comment, also there a significan typo in show_popup I didn’t change so I’ll fix that when I get home. |
I could not find anything wrong in your code that would point to the reason, I would say ship-it it is better than nothing, we could probably document this limitation |
|
I randomly came across this. I don't use sublime much anymore, was this feature added in a separate commit? I can update the code if needed. |
|
Any plans to merge this PR soon? |
4 participants
Hi, this is my pull request for #862 . I know the contributing guide says to wait for the issue to be discussed, but I'm kinda impatient and I wanted this enhancement to be out there for others who want the feature.
Since this is a GUI feature, I didn't add any tests. Tell me if this should be fixed.
This is the first Sublime plugin I'm working on, and I added some comments(questions) in the code, any assistance would be appreciated.
Fixes #862