Abort Running File before Autosync/Stop/SoftReset, abort REPL before AutoSync#31
Open
kai-morich wants to merge 5 commits intoDanielBustillos:mainfrom
Open
Abort Running File before Autosync/Stop/SoftReset, abort REPL before AutoSync#31kai-morich wants to merge 5 commits intoDanielBustillos:mainfrom
kai-morich wants to merge 5 commits intoDanielBustillos:mainfrom
Conversation
Prevents Autosync error by blocked serial port
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent autosync (auto-upload on save) failures caused by the serial port being held by an active “Run File” terminal or an open REPL terminal.
Changes:
- Adds run-file terminal execution tracking and a new
abortRunFileTerminal()helper that sends Ctrl-C when an mpremote command is running. - Initializes terminal tracking on extension activation.
- Before autosync upload, aborts any running run-file command and closes the REPL terminal to avoid port conflicts.
Reviewed changes
Copilot reviewed 2 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/mpremoteCommands.ts | Adds run-file terminal busy tracking, initialization hook, and an abort helper. |
| src/extension.ts | Initializes tracking on activate; aborts run-file + closes REPL before autosync upload. |
| dist/mpremoteCommands.js | Built output reflecting new tracking/abort exports and logic. |
| dist/mpremoteCommands.js.map | Source map update for mpremoteCommands build output. |
| dist/extension.js | Built output reflecting new activation init + autosync pre-steps. |
| dist/extension.js.map | Source map update for extension build output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The command might already have been ended, so we send a superfluous ^C, but the previous more sophisticated solution with vscode.window.onDidEndTerminalShellExecution() only works for some shells, e.g. on Windows only after 'Set-ExecutionPolicy -ExecutionPolicy ...'
kai-morich
changed the title
kai-morich
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents Autosync error by blocked serial port