Repository navigation
Install T2 Wi-Fi firmware when macOS was erased - #17
Open
DanielJBurbridge wants to merge 3 commits into
Open
DanielJBurbridge wants to merge 3 commits into
DanielJBurbridge wants to merge 3 commits into
Conversation
A full-disk install has no macOS volume for apple-bcm-firmware-fetcher to read, so BCM4364 Macs such as the 2018 MacBookPro15,2 come up with no firmware or NVRAM. Download Apple's recovery image in that case and reload brcmfmac. Co-authored-by: Daniel Burbridge <DanielJBurbridge@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When macOS has been erased on a supported T2 Mac, try the normal on-disk firmware fetch first, then use an Apple Sonoma recovery image to extract and rename the required Broadcom firmware/NVRAM. Restrict the fallback by T2/DMI detection and exclude the unsupported iMac Pro recovery path. Setup is best-effort and image first boot skips the download.
Bound recovery metadata/image/chunklist downloads and the total deadline. Track child process groups and clean up on exit/signals without killing siblings; retain paths and report errors when unmount or detach fails. The root entry uses Omarchy's shared environment setup.
Related: omacom#17743, omacom#7671, omacom#17755.
Validation on 8 November 2026:
bash test/shell.d/t2-wifi-firmware-test.shpassed (isolated fixtures, graphical session disabled).No real Apple recovery download/mount, module reload or Wi-Fi scan on T2 hardware.
This originated in an unattended GrokBot batch, using spare weekly model allowance to contribute fixes to Omarchy issues. The batch needed more review before submission. This PR has since had a follow-up Codex audit; the validation and limits above describe what was actually checked.