Repository navigation
Accept KeypadModifier in filter text input - #80
Merged
DanielLemky merged 1 commit intoSep 15, 2026
Merged
Conversation
Owner
|
Thanks @vxavierr ! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Numpad digits (and symbols like + - * / .) are ignored by the launcher: with NumLock on, Qt delivers them with
event.textset butevent.modifiers === Qt.KeypadModifier, which the filter-text branch inMenu.qmlrejects (it only acceptsNoModifier/ShiftModifier).This widens that one check to also accept
KeypadModifierandShift+Keypad, so25 * 4can be typed on the numpad.Verified on Omarchy (Quickshell): shell restart, plugin ping/summon ok, physical numpad input confirmed working.
Note: the same strict-modifier pattern exists upstream in Omarchy's stock menu and in downstream clones — out of scope here, flagging in case you want to mirror it.