Expand terminal agent support and harden status detection - #7
Draft
DanielOu1208 wants to merge 3 commits into
Draft
Expand terminal agent support and harden status detection#7DanielOu1208 wants to merge 3 commits into
DanielOu1208 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root causes fixed
Project trust,Trust, andDo not trust, while the detector only recognized older wording.The fix uses libghostty's native title-change callback, bounds title decoding to 1,024 bytes and 256 sanitized characters, rechecks PTY generation at delivery, and invalidates coordinator buffers by epoch on restart.
Validation
xcodebuild test -project GhostNotch.xcodeproj -scheme GhostNotch -destination 'platform=macOS'xcodebuild analyze -project GhostNotch.xcodeproj -scheme GhostNotch -destination 'platform=macOS' CODE_SIGNING_ALLOWED=NOpython3 scripts/remove-agent-hooks.py --self-testgit diff --checkShellCheck reports the pre-existing SC2115 warning in the untouched
scripts/build-ghostty-vt.sh; this PR does not alter that script.Manual acceptance still pending
Agent marks remain third-party property and are included only for product identification; their inclusion does not imply affiliation, sponsorship, or endorsement.