Skip to content

chore: add rSHUD submodule + OpenSpec change#24

Merged
DankerMu merged 1 commit into
mainfrom
feature/issue-19-rshud-submodule-openspec
Feb 9, 2026
Merged

chore: add rSHUD submodule + OpenSpec change#24
DankerMu merged 1 commit into
mainfrom
feature/issue-19-rshud-submodule-openspec

Conversation

@DankerMu
Copy link
Copy Markdown
Owner

@DankerMu DankerMu commented Feb 9, 2026

Summary

  • Add rSHUD/ as a submodule (fork: DankerMu/rSHUD)
  • Land OpenSpec change refactor-r-spatial-stack-sf-terra
  • Update root submodule workflow notes

Spec / proposal

  • OpenSpec change id: refactor-r-spatial-stack-sf-terra

Testing

  • openspec validate refactor-r-spatial-stack-sf-terra --strict --no-interactive

Closes #19

@DankerMu
Copy link
Copy Markdown
Owner Author

DankerMu commented Feb 9, 2026

Review: spec-driven-workflow

  • Scope: Small and matches [SHUD-NC] 以 submodule 管理 rSHUD + 落地 OpenSpec 提案 #19 (submodule wiring + OpenSpec change landing).
  • Spec/contract:
    • OpenSpec change refactor-r-spatial-stack-sf-terra is present and validates.
  • Repo hygiene:
    • .gitmodules correctly points rSHUD to the fork.
    • Root AGENTS.md documents the 3-submodule workflow clearly.
  • CI: OpenSpec + Python smoke are green.

@DankerMu
Copy link
Copy Markdown
Owner Author

DankerMu commented Feb 9, 2026

Review: spec-driven-workflow (via codeagent)

Review Summary

  • Submodule wiring looks correct: rSHUD is added in .gitmodules and as a gitlink (no extra behavior changes beyond introducing the submodule).
  • Root docs are updated appropriately for the third submodule and workflow (AGENTS.md).
  • OpenSpec change is well-formed: proposal + tasks + (optional) design + delta spec are present, and openspec validate refactor-r-spatial-stack-sf-terra --strict passes.

Issues Found

  • [MAJOR] OpenSpec approval gate ambiguity: this PR contains both the proposal and an implementation step (“Repo wiring” is already done, but still unchecked in openspec/changes/refactor-r-spatial-stack-sf-terra/tasks.md). Either split into (A) proposal-only PR then (B) implementation PR after approval, or explicitly treat this PR as the approval PR and update the “Repo wiring” tasks accordingly.
  • [MINOR] Follow-up hygiene: tasks propose installing into .Rlib/, but .Rlib/ is not ignored in .gitignore yet; add it before any local-R-lib install work lands to avoid accidental commits.
  • [NIT] CI doesn’t checkout submodules (fine for current jobs). If future CI touches rSHUD/ or other submodules, set actions/checkout to fetch submodules.

Decision
PASS — score 4/5.

@DankerMu DankerMu merged commit 79af5c6 into main Feb 9, 2026
5 checks passed
@DankerMu DankerMu deleted the feature/issue-19-rshud-submodule-openspec branch February 9, 2026 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SHUD-NC] 以 submodule 管理 rSHUD + 落地 OpenSpec 提案

1 participant