feat: Phase A NetCDF forcing validation pass (10-day QHH)#36
Merged
Conversation
- shud.yaml nc profile: add forcing.kv.CMFD_PRECIP_UNITS=MM_HR override, set output_mode=legacy for Phase A validation - shudnc.py render-shud-cfg: support forcing.kv dict for arbitrary KEY VALUE overrides in cfg.forcing (e.g. CMFD_PRECIP_UNITS) - compare_forcing.py: add CSV quantization matching (precip 4dp, temp 2dp, RH 4dp, wind 2dp, radiation int) + CMFD_PRECIP_UNITS override support - Update SHUD submodule ref (PR #78: off-by-one fix + quantization) Verification: all 5 forcing variables max_abs_diff=0, output .dat binary identical, baseline unbroken.
Owner
Author
Review: SHUD-NC PR #36shud.yaml
shudnc.py render-shud-cfg kv supportInput validation is thorough (type check, null, whitespace). Keys uppercased. Appended after adapter defaults allowing override. compare_forcing.py
SHUD submodule refPoints to PR #78 commit (off-by-one fix + quantization). Verification10-day QHH: all 5 forcing vars max_abs_diff=0, output .dat binary identical, baseline unbroken. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase A (NetCDF Forcing) 验证通过。NetcdfForcingProvider 直接读取 CMFD2 NetCDF 原始文件,与 AutoSHUD 生成的 baseline CSV forcing 完全一致。
Changes
projects/qhh/shud.yaml
forcing.kv.CMFD_PRECIP_UNITS: MM_HRoverrideoutput_mode: legacyfor Phase A validationtools/shudnc.py
render-shud-cfg: supportforcing.kvdict for arbitrary KEY VALUE overrides incfg.forcingtools/compare_forcing.py
CMFD_PRECIP_UNITSoverride fromcfg.forcingSHUD submodule
Verification Results
10-day QHH run (END=730, START=1):
Dependencies