Skip to content

fix: derive radiation semantics from FORCING_CFG RADIATION_KIND#70

Merged
DankerMu merged 1 commit into
masterfrom
codex/issue-68-radiation-kind
Feb 8, 2026
Merged

fix: derive radiation semantics from FORCING_CFG RADIATION_KIND#70
DankerMu merged 1 commit into
masterfrom
codex/issue-68-radiation-kind

Conversation

@DankerMu
Copy link
Copy Markdown
Owner

@DankerMu DankerMu commented Feb 8, 2026

Closes #68.

  • Adds FORCING_CFG parsing for PRODUCT/RADIATION_KIND.
  • Defaults RADIATION_KIND to SWNET for ERA5 when missing (avoids double-albedo on SSR).
  • Errors if cfg.para RADIATION_INPUT_MODE conflicts with FORCING_CFG RADIATION_KIND.
  • Logs effective radiation semantics at startup.

@DankerMu
Copy link
Copy Markdown
Owner Author

DankerMu commented Feb 8, 2026

PR Review (#68 radiation semantics)

  • CI: baseline + NETCDF builds passed.
  • Change is localized to Control_Data::read(): derives effective radiation semantics from FORCING_CFG (RADIATION_KIND) when FORCING_MODE=NETCDF.
  • Sensible defaulting: PRODUCT=ERA5 => SWNET when RADIATION_KIND is absent (avoids double-albedo when using SSR/net shortwave).
  • Safety: fatal error on explicit cfg.para RADIATION_INPUT_MODE conflicting with FORCING_CFG RADIATION_KIND (prevents silent wrong ET).
  • Startup logging now reports the effective radiation mode/kind.

LGTM.

@DankerMu DankerMu merged commit 9f2e0c8 into master Feb 8, 2026
2 checks passed
@DankerMu DankerMu deleted the codex/issue-68-radiation-kind branch February 8, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[P0] NetCDF forcing: apply RADIATION_KIND + fix ERA5 SSR (SWNET) double-albedo

1 participant