Skip to content

fix: NetCDF output metadata + CRS hook + sink ownership#71

Merged
DankerMu merged 2 commits into
masterfrom
codex/issue-69-ncoutput-metadata
Feb 8, 2026
Merged

fix: NetCDF output metadata + CRS hook + sink ownership#71
DankerMu merged 2 commits into
masterfrom
codex/issue-69-ncoutput-metadata

Conversation

@DankerMu
Copy link
Copy Markdown
Owner

@DankerMu DankerMu commented Feb 8, 2026

Closes #69.

  • Add CF units + standard_name for mesh coordinates (mesh_node_x/y, mesh_face_x/y).
  • Add optional CRS_WKT support (writes crs variable with spatial_ref / crs_wkt, links via grid_mapping).
  • Fix Conventions for river/lake files (CF-only; no UGRID claim).
  • Warn when SCHEMA is set (currently ignored).
  • Make print sinks lifetime/ownership explicit via std::shared_ptr.

@DankerMu
Copy link
Copy Markdown
Owner Author

DankerMu commented Feb 8, 2026

PR Review (#69 NetCDF output metadata hardening)

  • CI: baseline + NETCDF builds passed.
  • CF/UGRID metadata: adds units + standard_name for mesh_node_x/y and mesh_face_x/y (fixes missing-units surprises).
  • Conventions: keeps "CF-1.10 UGRID-1.0" for element mesh outputs, and uses "CF-1.10" for river/lake files (no UGRID over-claim).
  • CRS hook: optional NCOUTPUT_CFG CRS_WKT writes a crs variable (spatial_ref / crs_wkt) and links via grid_mapping; warns when missing.
  • SCHEMA: warns when set (explicitly ignored for now; avoids silent no-op).
  • Sink ownership: Print_Ctrl now stores sinks via std::shared_ptr; NetCDF sinks/files use shared ownership to make lifetimes explicit and robust to refactors.

LGTM.

@DankerMu DankerMu merged commit 8bfc65c into master Feb 8, 2026
2 checks passed
@DankerMu DankerMu deleted the codex/issue-69-ncoutput-metadata branch February 8, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[P1] NetCDF output: CF/UGRID metadata + schema handling + Conventions + sink ownership hardening

1 participant