Skip to content

feat: enable terrain solar radiation (TSR) by default#77

Merged
DankerMu merged 1 commit into
masterfrom
feat/tsr-default-on
Feb 13, 2026
Merged

feat: enable terrain solar radiation (TSR) by default#77
DankerMu merged 1 commit into
masterfrom
feat/tsr-default-on

Conversation

@DankerMu
Copy link
Copy Markdown
Owner

Change terrain_radiation default from 0 to 1 in Model_Control.hpp, so TSR correction is active out of the box.

@DankerMu
Copy link
Copy Markdown
Owner Author

Review

Single-line change: terrain_radiation default 0 → 1 in Model_Control.hpp.

  • Correctness: TSR feature already fully implemented and tested; this only flips the default.
  • Backward compat: Users who explicitly set TERRAIN_RADIATION=0 in .cfg are unaffected (runtime config overrides default).
  • Risk: Low. TSR validation suite (validation/tsr/) covers this path.
  • CI: Build (baseline) ✅, Build (NETCDF=1) ✅

LGTM.

Change terrain_radiation default from 0 to 1 so TSR correction
is active out of the box.
@DankerMu DankerMu force-pushed the feat/tsr-default-on branch from ab22c75 to b802cf0 Compare February 13, 2026 13:02
@DankerMu
Copy link
Copy Markdown
Owner Author

Review (rebased)

Same single-line change after rebase. All builds pass.

LGTM.

@DankerMu DankerMu merged commit c1fcd8a into master Feb 13, 2026
5 checks passed
@DankerMu DankerMu deleted the feat/tsr-default-on branch February 13, 2026 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant