Tag every trace event with the program version (trace-client 0.4.0) - #352
Merged
Merged
Conversation
The vendored trace client is updated to 0.4.0, which requires the program version at construction and tags every event with it. The builder is given `getDescription().getVersion()`, and the hand-added version tag on startup is removed as redundant. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AuTszT2gqv7nLVYrtKD4ji
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vendored trace client is updated to 0.4.0 (trace-client-java), so every usage event,
commandincluded, now carries the plugin version as the tagversion; before, onlystartupdid.getDescription().getVersion()(the plugin.yml version, filled in by the build), which is the same expression the startupversiontag already used.versiontag onstartupis removed, since the client now adds it.Test:
mvn clean package --batch-modepassed locally on JDK 11 (source/target 1.8; CI builds on JDK 8, which is not installed locally); 16 tests, 0 failures.🤖 Generated with Claude Code
https://claude.ai/code/session_01AuTszT2gqv7nLVYrtKD4ji
drafted by Claude on behalf of Daniel Stephenson