Surface const-sql diagnostics from generated files - #178
Merged
mgravell merged 2 commits intoAug 20, 2026
Conversation
When the `sql` argument resolves to a `const string`, the SQL parameter analysis already runs, but its diagnostics (DAP214, etc.) were anchored at the constant's declaration. For a constant emitted into a generated file, the analyzer driver drops diagnostics there (generated-code suppression), so only the call-site DAP018 survived and it looked like the SQL was never analyzed. Re-home the SQL-parse diagnostics onto the call-site sql argument when the declaration is in generated code, so they stay visible. Inline literals and constants in hand-written documents (same or sibling file) keep their precise declaration-token location. Closes DapperLib#177
mgravell
approved these changes
Aug 20, 2026
mgravell
left a comment
mgravell
left a comment
Member
There was a problem hiding this comment.
thanks - the root cause is exactly right, LGTM; I ate the merge conflicts on your behalf: that's my fault for being slow in getting through backlog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the
sqlargument resolves to aconst string, the SQL parameter analysis already runs, but its diagnostics (DAP214, etc.) were anchored at the constant's declaration. For a constant emitted into a generated file, the analyzer driver drops diagnostics there (generated-code suppression), so only the call-site DAP018 survived and it looked like the SQL was never analyzed.Re-home the SQL-parse diagnostics onto the call-site sql argument when the declaration is in generated code, so they stay visible. Inline literals and constants in hand-written documents (same or sibling file) keep their precise declaration-token location.
Closes #177