Open
Conversation
- Add #![cfg_attr(not(feature = "std"), no_std)] for conditional no_std - Replace std::collections::HashMap with hashbrown::HashMap in no_std mode - Replace std::arch with core::arch for SIMD intrinsics - Replace std::cmp, std::fmt, std::hash, std::mem, std::slice with core equivalents - Add num-traits with libm feature for f32 math methods (sqrt, round, powf) - Feature-gate num_traits::Float import for no_std only - Use core::error::Error (now stable in core) - Make "std" feature the default, with "capi" requiring "std" - Fix collapsible_if clippy warnings in vpsearch.rs Tested on thumbv7em-none-eabihf target.
Owner
|
Hey @lilith! I'm up to add no_std support, yet I'm not ready to test it right now, as I'm fully loaded at the moment. Here are some comments I can make after the first glance:
#[cfg(not(feature = "std"))]
use crate::no_std_compat::*Also, it's probably a good idea to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
no_std + allocsupport for embedded/WASM use cases.Closes #2
Changes
#![cfg_attr(not(feature = "std"), no_std)]for conditional no_stdhashbrown::HashMapin no_std mode (std usesstd::collections::HashMap)num-traitswith libm feature for f32 math methods in no_stdstd::arch→core::archfor SIMD intrinsicsstd::cmp,std::fmt,std::hash,std::mem,std::slice→core::*core::error::Error(stable since Rust 1.81)num_traits::Floatimport for no_std onlycollapsible_ifclippy warnings in vpsearch.rsUsage
Testing
thumbv7em-none-eabihf(no_std target)-D warnings