odroid_h4 config: set edk2 rev to odroid v0.9.1 sb user mode fix - #723
Draft
philipanda wants to merge 738 commits into
Draft
philipanda wants to merge 738 commits into
philipanda wants to merge 738 commits into
Conversation
Adding PMC mux_conn entries to devicetree causes coreboot to program AUX bias pads before the multiphase silicon init according to typec_aux_bias_pads values. However, it seems too late in the intialization flow and Type-C displays stop working. In order to have the PMC mux_conn generate the ACPI code and still keep the Type-C display working in FW, let FSP program the AUX bias pads. TEST=Check Type-C display works on VP3210 in both OS and FW. Change-Id: Ibb12932961bf2dcaa9031af8f6fee9a48a61192a Upstream-Status: Pending Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Change-Id: Ifc57b49ff2f8d4611145ac8dbcc35fddb3ebd3b7 Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Upstream-Status: Inappropriate [Dasharo downstream] Change-Id: Idbfccb37e1b0331f6847ceb00945c23ea7cc2ea2 Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
If uploading for the first time for a new board, directory structure might not be in place yet. Upstream-Status: Inappropriate [Dasharo downstream] Change-Id: I698d960771b7295d82133a92f33f284f8787bd74 Signed-off-by: Maciej Pijanowski <maciej.pijanowski@3mdeb.com>
Change-Id: I3ddf149ac65495ab2b56b7f84123d48acc807e09 Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Change-Id: I3a4de5dc406bf827e474f3986373e53c64352e7e Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Change-Id: I39af3c0e5615bd72e481711148fcdbabb7c19719 Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Maciej Pijanowski <maciej.pijanowski@3mdeb.com> Signed-off-by: Pawel Langowski <pawel.langowski@3mdeb.com>
Upstream-Status: Inappropriate [Dasharo downstream] Change-Id: Ieab18affd29b3e8ca749ea877a349da9067ba251 Signed-off-by: Maciej Pijanowski <maciej.pijanowski@3mdeb.com> Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Change-Id: I601f5615ec018cc6b0703d8d34f145fd588f3224 Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
…AC loss Change-Id: I1f6d1d6a03bef57407fd9ad07014502a0e61bb0c Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Change-Id: Ib4a56265c6efe52c9d0365f4edd4f569dee1dc1e Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Change-Id: I42048df1d854a028c6e804ba5ad85f640ca17160 Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
…mp to rc6 Change-Id: I7b992f241312b36ce8d1819fe7234a0a2ecae98b Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Change-Id: I7d8f7d24f4b80d482a0e7606ebe3a05eb6fec528 Upstream-Status: Pending Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
Change-Id: Ib01c85e3985c2899ce923d65cb98e167bf71209c Upstream-Status: Pending Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
Change-Id: Id7936d08b90d0961ee2712ff148cd3b52eda1073 Upstream-Status: Pending Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
Change-Id: I07a310cfbac417001014c009abe3a17d4605227d Upstream-Status: Pending Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
Change-Id: Ib9ea59345503071994f0cff39d01b18cbcf2413e Upstream-Status: Pending Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
Change-Id: I40ea09095585285965f5225e95e7c238770a33e1 Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
Change-Id: I6b201bf185d6ae47396a842c8d9bcc68d2fc82c0 Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
Change-Id: I3b3d862562e8aad464a4a39c0a331da8a89f798e Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
Change-Id: I2907d304f4deb657e4a750ef6ed59e22cca1e5f8 Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
…bled mode Disable/hdie HECI if ME is in debug/HAP or soft disabled mode. The HECI should be hidden if ME is disabled using HAP or HECI message. Match the behavior of other platforms which disable HECI in FSP. Change-Id: Ieea22d23663290390d620b63f1ea4a00e4242261 Upstream-Status: Pending Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Change-Id: Ie5d7293e13310d9252c84e3c1b314d2c74555c86 Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Platforms that are unable to keep RAM content across rebots, e.g. VP2410, it is necessary to use UEFI variable-backed TPM PPI. Otherwise the requested actions are not processed after a reset or reboot. Change-Id: If73e1a83f3d7644d3b159e54a58d0bd1e6e90978 Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Change-Id: I554031efb1706656b8e31de762df383bd7bf258f Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Change-Id: Ife627a900bd4c9235f20f6e0665288bfe5a587ca Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Change-Id: Id3032433e699111d66273700a216b0ef8563cccd Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Change-Id: I142f32a1ef41ea67f0bc3fcbc3de3998d677002b Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Change-Id: I15488b891dcb28903fdb69c029950fee1b5365a6 Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
EDK will publish its own version of the log after parsing and importing coreboot's log discovered through CBMEM. Publishing is done by appending a table, so coreboot must avoid adding corresponding log tables to let OS find a more complete one from EDK. Upstream-Status: Pending Change-Id: Iec92c2b5c426ee003e81996937862d81cb4ead24 Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
No functional changes. This replaces a macro with an inline function to make code more readable and more convenient to extend in the future. Upstream-Status: Pending Change-Id: I456bc3bb749a9b58fba72f5562195525e55290bf Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
This event log format option automatically selects TCG log format depending on which TPM is present. Upstream-Status: Pending Change-Id: I1997396f24ff6362fe64ac56f8e61efcf2ffb0f7 Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Move this check to pre-push rather then pre-commit, to avoid the possibility of losing longer commit message if pre-commit fails. pre-push hook must be installed additionally to make it work (by default, only the pre-commit hook is installed) pre-commit install -t pre-push Change-Id: Ie205b55a5dcab759fd1b194378d7f73bc9992b31 Signed-off-by: Maciej Pijanowski <maciej.pijanowski@3mdeb.com> Upstream-Status: Inappropriate [Dasharo downstream]
Change-Id: I74d9fa455260df8213afb8a92b587095e948c56b Signed-off-by: Maciej Pijanowski <maciej.pijanowski@3mdeb.com> Upstream-Status: Inappropriate [Dasharo downstream]
Upstream-Status: Inappropriate [custom build script] Signed-off-by: Piotr Król <piotr.krol@3mdeb.com> Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
This change look for AIRGAP environment variable and if it is set it
perform airgap build of Dasharo for Odroid H4 and its version for
Intel Boot Guard.
This is required for security, privacy and trainers who would like to
perform 100% offline build.
To make that possible couple requirements have to be fulfilled:
- repository cannot be distcleaned, because it remove all artifacts, the
assumption is that provided repository already has all dependencies
fetched, so only make clean is made before proceeding
- since whole process rely on mounting edk2 as volume inside Dasharo SDK
container, workspace directory to which it would be mount needs proper
permissions otherwise docker will create mountpoint with root
privileges, what cause issues in further use and build process
- finally we take into consideration BUILD_TIMELESS environment
variable, which improve testability of build process and toolchain
change
This change was tested by:
1. cloning relevant version of edk2
2. cloning coreboot, cd coreboot
3. running checkout on ipxe:
docker run --rm --user $(id -u):$(id -g) -v $PWD:/home/coreboot/coreboot \
${DASHARO_SDK} \
make -C /home/coreboot/coreboot/payloads/external/iPXE checkout
4. Build
EDK2_REPO_PATH="${PWD}/../edk2" AIRGAP=1 BUILD_TIMELESS=1 ./build.sh odroid_h4_btg
EDK2_REPO_PATH="${PWD}/../edk2" AIRGAP=1 BUILD_TIMELESS=1 ./build.sh odroid_h4
Upstream-Status: Inappropriate [custom build script]
Signed-off-by: Piotr Król <piotr.krol@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Upstream-Status: Inappropriate [CI workflow and custom build script] Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Upstream-Status: Inappropriate [CI workflow] Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
The NV4X and NS5X ADL are the only with enabled ccache. Disable it for consistency. Also dasharo-sdk v1.6.0 does not have ccache installed which causes the build to fail. Upstream-Status: Inappropriate [custom configs] Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Fixes the issue with display not working in the firmware. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
FW performance measurement is required to measure difference in boot time with fast boot. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
philipanda
force-pushed
the
odroid-sb-usermode-fix
branch
from
July 25, 2025 07:37
5eaf372 to
c93ea29
Compare
miczyg1
force-pushed
the
odroid_h4_rel_v0.9.1
branch
2 times, most recently
from
August 2, 2025 21:46
28500ea to
43531c3
Compare
SergiiDmytruk
force-pushed
the
odroid_h4_rel_v0.9.1
branch
2 times, most recently
from
August 7, 2025 14:21
a022278 to
37c9db6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.