Fix HVC Garbage collection API#1230
Closed
me-processware wants to merge 1 commit into
Closed
Conversation
Collaborator
|
I was rather late in merging your PR. Currently there are merge conflicts. I'll try to fix those. |
|
Do i need to push the PR again to the beta branch? |
Collaborator
|
I'll merge it into the new beta |
|
sorry. that is was mu PR and did not see the HVC PR ;-) |
Collaborator
|
Merged into beta |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix HVC Garbage Collection API
Problem
HVC garbage collection stopped working due to API changes:
Solution
Testing
Tested with address in Emmeloord, successfully retrieves:
Works with both service=hvc and service=afvalstromen&sub=hvc