Conversation
… read,stateless write in user space
implementation of more zfs_file interfaces in user mode seek,flush,getattr and changes in pread,pwrite
aviksildc
commented
Jul 29, 2020
ZFSin/zfs/lib/libzpool/kernel.c
Outdated
| mbstowcs(buf, path, sizeof(buf)); | ||
| HANDLE hFile = CreateFileW( | ||
| buf, | ||
| GENERIC_READ | GENERIC_WRITE, |
Author
There was a problem hiding this comment.
You need to set this according to flags and mode params
| wchar_t buf[PATH_MAX]; | ||
| UNICODE_STRING uniName; | ||
| mbstowcs(buf, path, sizeof(buf)); | ||
| HANDLE hFile = CreateFileW( |
Author
There was a problem hiding this comment.
Can generic CreateFile() be used here instead?
| ); | ||
| if (hFile == INVALID_HANDLE_VALUE) | ||
| { | ||
| return E_FAIL; |
Author
There was a problem hiding this comment.
How is E_FAIL defined? Can this be replaced with EIO? Idem for all such uses.
ZFSin/zfs/lib/libzpool/kernel.c
Outdated
| NULL | ||
| ); | ||
| if (hFile == INVALID_HANDLE_VALUE) | ||
| { |
Author
There was a problem hiding this comment.
Follow coding guidelines.
"The opening brace ( { ) should be on the same line as the structure tag, and the
closing brace should be alone on a line in column 1."
Example:
if (condition) {
statements;
} else {
statements;
}
aviksildc
commented
Jul 30, 2020
| } | ||
| /*ARGSUSED*/ | ||
|
|
||
| DWORD zfs_file_off(zfs_file_t* hFile) // 1 |
Author
There was a problem hiding this comment.
Would be good to document what the interface does, like in ZoL:
/*
* Request current file pointer offset
*
* fp - pointer to file
*
* Returns current file offset.
*/
Idem for all other interfaces.
| Microsoft Visual Studio Solution File, Format Version 12.00 | ||
| # Visual Studio 15 | ||
| VisualStudioVersion = 15.0.27004.2005 | ||
| # Visual Studio Version 16 |
| {9AFC9A86-1D07-49E1-9296-F7A3979B751D}.Debug|ARM64.Deploy.0 = Debug|ARM64 | ||
| {9AFC9A86-1D07-49E1-9296-F7A3979B751D}.Debug|x64.ActiveCfg = Debug|x64 | ||
| {9AFC9A86-1D07-49E1-9296-F7A3979B751D}.Debug|x64.Build.0 = Debug|x64 | ||
| {9AFC9A86-1D07-49E1-9296-F7A3979B751D}.Debug|x64.Deploy.0 = Debug|x64 |
| { | ||
| int fd; | ||
| struct stat statbuf; | ||
| struct _stat64 statbuf; |
| * userland. | ||
| */ | ||
| #define ZPOOL_CACHE "/etc/zfs/zpool.cache" | ||
| #define ZPOOL_CACHE "\\SystemRoot\\System32\\drivers\\zpool.cache" |
| //int zfs_file_pread(zfs_file_t *fp, void *buf, size_t len, loff_t off, | ||
| // ssize_t *resid); | ||
|
|
||
| /* |
Author
There was a problem hiding this comment.
Check for commented sections.
| return (errno); | ||
|
|
||
| if (fstat_blk(fd, &st) == -1) { | ||
| if (fstat(fd, &st) == -1) { |
|
|
||
| ASSERT(startvp == rootdir); | ||
| (void) sprintf(realpath, "/%s", path); | ||
| (void) sprintf(realpath, "%s", path); |
ZFSin/zfs/module/zfs/spa_config.c
Outdated
| "", spa_config_path); | ||
|
|
||
| file = kobj_open_file(pathname); | ||
| file = kobj_open_file("C:\\WINDOWS\\System32\\drivers\\zpool.cache"); |
| return -1; | ||
|
|
||
| ntstatus = ZwCreateFile(&handle, | ||
| GENERIC_WRITE, |
Author
There was a problem hiding this comment.
handle flags and mode properly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.