[CWS] Rename activity profile field from is_exec_child to is_exec_exec#265
Open
[CWS] Rename activity profile field from is_exec_child to is_exec_exec#265
Conversation
lebauce
changed the title
|
Is this bool still true if it's >2 execs? |
sgnn7
reviewed
Aug 8, 2023
| bool envs_truncated = 20; | ||
|
|
||
| bool is_exec_child = 21; | ||
| bool is_exec_exec = 21; |
Contributor
There was a problem hiding this comment.
Question: Renaming fields is usually discouraged - why not create a new field and deprecate the old one? If we keep the name, will this break any expected serialized marshalling/unmarshalling based from this protobuf?
Sidenote: I'm not fully sure what is_exec_exec would mean in the context of a process so I'm hesitant to say that the new name is an improvement over the old one.
spikat
approved these changes
Aug 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist
Reviewers: please see the review guidelines.