add ecs task payload

[kangyili]

What does this PR do?

Agent PR DataDog/datadog-agent#21836

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

Reviewers: please see the review guidelines.

[fisherevans]

nit: your code uses tabs, but the rest of the file uses spaces for indentation.

[xlucas]

That looks odd to add an ECS resource to a K8sResource enum, we could rename it to OrchestratorResource and start at a different offset for ECS tasks so we have room for new Kubernetes resources.

[kangyili]

agent-payload/proto/process/agent.proto

Lines 742 to 769 in 7f5124f

	enum OrchestratorResource {
	OrchestratorResource_UNSPECIFIED = 0;
	POD = 1;
	REPLICASET = 2;
	SERVICE = 3;
	NODE = 4;
	CLUSTER = 5;
	JOB = 6;
	CRONJOB = 7;
	DAEMONSET = 8;
	STATEFULSET = 9;
	PERSISTENTVOLUME = 10;
	PERSISTENTVOLUMECLAIM = 11;
	ROLE = 12;
	ROLEBINDING = 13;
	CLUSTERROLE = 14;
	CLUSTERROLEBINDING = 15;
	SERVICEACCOUNT = 16;
	INGRESS = 17;
	DEPLOYMENT = 18;
	NAMESPACE = 19;
	CRD = 20;
	CR = 21;
	VERTICALPODAUTOSCALER = 22;
	HORIZONTALPODAUTOSCALER = 23;
	NETWORKPOLICY = 24;
	ECSTASK = 150;
	}

[aureleoules]

Looks good to me

[aureleoules]

nit: Maybe specify platformVersion instead of version as it may be confusing since taskVersion exists. Same for family -> platformFamily ?

[kangyili]

I'll delete taskVersion. family and version here stand for task definition family and version

[kangyili]

My bad , actually taskVersion is a custom field that is used to track changes. I'll rename it to resource version

[aureleoules]

Is this field supposed to contain both memory and cpu limits like this?
{"cpu": 8, "memory": 4}

[kangyili]

Yes. I feel I still prefer to use a map instead of using two dedicated fields as we can check if the value is set or not

if val, ok := limits["CPU"]; ok {
			//do somthing
}

[fisherevans]

maybe we should define some constants for the keys?

[kangyili]

we can't use enum type as key for a map in proto 😞
It's a usage we are already using https://github.com/DataDog/agent-payload/blob/master/proto/process/agent.proto#L996

[aureleoules]

It seems it's impossible to define constant strings in protobuf3. And if we were to split the limits field into 2 (memLimits, cpuLimits) it's not possible to check if the field has a value or not since numeric types are initialized with 0 in golang.
So leaving this as is is the best option I think

[kangyili]

This change matches https://github.com/DataDog/datadog-agent/blob/076db95494f6cd8ee8d53fb469f44fb40b923c46/pkg/orchestrator/model/types.go#L83