Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions packages/rum-core/src/domain/getSelectorFromElement.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -219,4 +219,23 @@ describe('isSelectorUniqueAmongSiblings', () => {
`)
expect(isSelectorUniqueAmongSiblings(element, 'DIV', 'HR')).toBeTrue()
})

it('returns false when element is in DocumentFragment with matching siblings', () => {
const fragment = document.createDocumentFragment()
const div1 = document.createElement('div')
const div2 = document.createElement('div')
fragment.appendChild(div1)
fragment.appendChild(div2)

// The function should return false because div2 matches 'DIV' selector
expect(isSelectorUniqueAmongSiblings(div1, 'DIV', undefined)).toBeFalse()
})

it('returns true when element is in DocumentFragment with no matching siblings', () => {
const fragment = document.createDocumentFragment()
const div = document.createElement('div')
fragment.appendChild(div)

expect(isSelectorUniqueAmongSiblings(div, 'DIV', undefined)).toBeTrue()
})
})
18 changes: 15 additions & 3 deletions packages/rum-core/src/domain/getSelectorFromElement.ts
Original file line number Diff line number Diff line change
Expand Up @@ -249,10 +249,22 @@ export function isSelectorUniqueAmongSiblings(
isSiblingMatching = (sibling) => sibling.querySelector(scopedSelector) !== null
}

const parent = currentElement.parentElement!
let sibling = parent.firstElementChild
// Check siblings by iterating directly through previousElementSibling and nextElementSibling.
// This works even when parentElement is null (e.g., when parent is a DocumentFragment).

// Check previous siblings
let sibling = currentElement.previousElementSibling
while (sibling) {
if (isSiblingMatching(sibling)) {
return false
}
sibling = sibling.previousElementSibling
}

// Check next siblings
sibling = currentElement.nextElementSibling
while (sibling) {
if (sibling !== currentElement && isSiblingMatching(sibling)) {
if (isSiblingMatching(sibling)) {
return false
}
sibling = sibling.nextElementSibling
Expand Down