Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a proposal to allow mocking values (mostly functions) within tests.
The current way to mock values used within a function is to pass them as argument of that function. For example:
However, forces to have unecessary extra arguments in functions. Impls also need to be propagated within subfunctions:
This PR introduce a new way to mock values that is similar to a lightweight dependency injection system. Values that can be mocked should be wrapped in a
mocked()call when used, and tests can usemockValue()to replace the value ormockWithSpy()to replace it with a jasmine spy. The example above would be implemented as:Changes
Test instructions
Checklist